From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbbJGHb6 (ORCPT ); Wed, 7 Oct 2015 03:31:58 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:35266 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbbJGHb4 (ORCPT ); Wed, 7 Oct 2015 03:31:56 -0400 Date: Wed, 7 Oct 2015 09:31:52 +0200 From: Ingo Molnar To: Chris Metcalf Cc: Michael Cree , Matt Turner , Michael Ellerman , Yoshinori Sato , Alexey Dobriyan , Rasmus Villemoes , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov , linux-alpha@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v2 3/3] strscpy: zero any trailing garbage bytes in the destination Message-ID: <20151007073152.GA8974@gmail.com> References: <1444159429-4788-1-git-send-email-cmetcalf@ezchip.com> <1444159429-4788-4-git-send-email-cmetcalf@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444159429-4788-4-git-send-email-cmetcalf@ezchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Chris Metcalf wrote: > It's possible that the destination can be shadowed in userspace > (as, for example, the perf buffers are now). So we should take > care not to leak data that could be inspected by userspace. > > Signed-off-by: Chris Metcalf Please always preserve credits for who found the bug: Reported-by: Alexey Dobriyan Also, you should credit the kbuild-bot for the cross-arch build breakages that your other patches address: Reported-by: kbuild test robot Thanks, Ingo