From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751695AbbJGLV6 (ORCPT ); Wed, 7 Oct 2015 07:21:58 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33660 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbbJGLV4 (ORCPT ); Wed, 7 Oct 2015 07:21:56 -0400 Date: Wed, 7 Oct 2015 16:51:49 +0530 From: Viresh Kumar To: Greg Kroah-Hartman Cc: Arnd Bergmann , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Stephen Boyd , Bartlomiej Zolnierkiewicz , Nishanth Menon , Dmitry Torokhov , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PM / OPP: fix debugfs files for 64-bit Message-ID: <20151007112149.GB22530@linux> References: <5706174.BUsqiXljxZ@wuerfel> <20151007105911.GC9892@linux> <20151007110302.GD9892@linux> <20151007110755.GA6601@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151007110755.GA6601@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07-10-15, 12:07, Greg Kroah-Hartman wrote: > Why would you be wanting to create a "unsigned long" as an api anyway? > Just force it to be u64 all the time, can't you do that? Okay, so the variable in question (lets say frequency) is an 'unsigned long' and that's how all the APIs of clock framework expect/define it. And you are probably saying that we do this: unsigned long freq; debugfs_create_u64((u64 *)&freq); Right? Or are you asking to update clock APIs to be converted to u64? This will break things on a 32 bit architecture where unsigned long is 32 bits long, as doing this will overwrite the next 32 bits: *freq = XYZ; -- viresh