[PATCH 1/2] mfd: lm3533: fix build warning

[PATCH 1/2] mfd: lm3533: fix build warning

[Sudip Mukherjee]

We were getting build warning about unused variable 'ret'.
The commit c749db571dcf has removed the use of ret but missed removing
the variable which is unused now.

Fixes: c749db571dcf ("mfd: lm3533: Simplify function return logic")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/mfd/lm3533-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
index 193ecee1..5abcbb2 100644
--- a/drivers/mfd/lm3533-core.c
+++ b/drivers/mfd/lm3533-core.c
@@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
 					const struct i2c_device_id *id)
 {
 	struct lm3533 *lm3533;
-	int ret;
 
 	dev_dbg(&i2c->dev, "%s\n", __func__);
 
-- 
1.9.1

[PATCH 2/2] mfd: rtsx: fix build warning

[Sudip Mukherjee]

We were getting build warning about unused variable 'err'.
The commit a3c29b099829 has removed the use of err but missed removing
the variable which is unused now.

Fixes: a3c29b099829 ("mfd: rtsx: Simplify function return logic")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/mfd/rtsx_pcr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
index b98cf1d..d63f3a8 100644
--- a/drivers/mfd/rtsx_pcr.c
+++ b/drivers/mfd/rtsx_pcr.c
@@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
 
 static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
 {
-	int err;
-
 	rtsx_pci_init_cmd(pcr);
 
 	while (*tbl & 0xFFFF0000) {
-- 
1.9.1

Re: [PATCH 2/2] mfd: rtsx: fix build warning

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

Hi Sudip,

[auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]

config: x86_64-randconfig-x003-201540 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
>> drivers/mfd/rtsx_pcr.c:572:2: error: 'err' undeclared (first use in this function)
     err = rtsx_pci_send_cmd(pcr, 100);
     ^
   drivers/mfd/rtsx_pcr.c:572:2: note: each undeclared identifier is reported only once for each function it appears in

vim +/err +572 drivers/mfd/rtsx_pcr.c

ada8a8a1 Wei WANG 2012-10-29  566  	while (*tbl & 0xFFFF0000) {
ada8a8a1 Wei WANG 2012-10-29  567  		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD,
ada8a8a1 Wei WANG 2012-10-29  568  				(u16)(*tbl >> 16), 0xFF, (u8)(*tbl));
ada8a8a1 Wei WANG 2012-10-29  569  		tbl++;
ada8a8a1 Wei WANG 2012-10-29  570  	}
ada8a8a1 Wei WANG 2012-10-29  571  
ada8a8a1 Wei WANG 2012-10-29 @572  	err = rtsx_pci_send_cmd(pcr, 100);
ada8a8a1 Wei WANG 2012-10-29  573  	if (err < 0)
ada8a8a1 Wei WANG 2012-10-29  574  		return err;
ada8a8a1 Wei WANG 2012-10-29  575  

:::::: The code at line 572 was first introduced by commit
:::::: ada8a8a13b13a2749818524a7949935f68d2b3eb mfd: Add realtek pcie card reader driver

:::::: TO: Wei WANG <wei_wang@realsil.com.cn>
:::::: CC: Samuel Ortiz <sameo@linux.intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 31195 bytes --]

Re: [PATCH 2/2] mfd: rtsx: fix build warning

[Sudip Mukherjee]

On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> Hi Sudip,
> 
> [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
v4.3-rc4 is not appropriate base. Please use next-20151007 for both.

regards
sudip

Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

[Fengguang Wu]

On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > Hi Sudip,
> > 
> > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> v4.3-rc4 is not appropriate base. Please use next-20151007 for both.

OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
the robot will select linux-next/master as the base tree.

Thanks,
Fengguang

Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

[Sudip Mukherjee]

On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> > On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > > Hi Sudip,
> > > 
> > > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> > v4.3-rc4 is not appropriate base. Please use next-20151007 for both.
> 
> OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
> the robot will select linux-next/master as the base tree.
Ok. Great. And for staging should it be [PATCH staging-testing] ?

regards
sudip

Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

[Fengguang Wu]

On Wed, Oct 07, 2015 at 09:11:25PM +0530, Sudip Mukherjee wrote:
> On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> > On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> > > On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > > > Hi Sudip,
> > > > 
> > > > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> > > v4.3-rc4 is not appropriate base. Please use next-20151007 for both.
> > 
> > OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
> > the robot will select linux-next/master as the base tree.
> Ok. Great. And for staging should it be [PATCH staging-testing] ?

It looks some patches already use the form [PATCH staging], I wonder
which branch Greg typically apply them to, staging-testing or staging-next?

Thanks,
Fengguang

Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

[Greg KH]

On Thu, Oct 08, 2015 at 08:56:38AM +0800, Fengguang Wu wrote:
> On Wed, Oct 07, 2015 at 09:11:25PM +0530, Sudip Mukherjee wrote:
> > On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> > > On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> > > > On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > > > > Hi Sudip,
> > > > > 
> > > > > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> > > > v4.3-rc4 is not appropriate base. Please use next-20151007 for both.
> > > 
> > > OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
> > > the robot will select linux-next/master as the base tree.
> > Ok. Great. And for staging should it be [PATCH staging-testing] ?
> 
> It looks some patches already use the form [PATCH staging], I wonder
> which branch Greg typically apply them to, staging-testing or staging-next?

I start by putting things in staging-testing to "test" them on my
systems, and yours, and if they survive, I then move them to -next.
staging-testing can be rebased if there is problems, but -next can not,
which is why I do this.

hope this helps,

greg k-h

Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

[Sudip Mukherjee]

On Thu, Oct 08, 2015 at 07:30:22AM +0100, Greg KH wrote:
> On Thu, Oct 08, 2015 at 08:56:38AM +0800, Fengguang Wu wrote:
> > On Wed, Oct 07, 2015 at 09:11:25PM +0530, Sudip Mukherjee wrote:
> > > On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> > > > On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> > > > > On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > > > > > Hi Sudip,
> > > > > > 
> > > > > > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> > > > > v4.3-rc4 is not appropriate base. Please use next-20151007 for both.
> > > > 
> > > > OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
> > > > the robot will select linux-next/master as the base tree.
> > > Ok. Great. And for staging should it be [PATCH staging-testing] ?
> > 
> > It looks some patches already use the form [PATCH staging], I wonder
> > which branch Greg typically apply them to, staging-testing or staging-next?
> 
> I start by putting things in staging-testing to "test" them on my
> systems, and yours, and if they survive, I then move them to -next.
> staging-testing can be rebased if there is problems, but -next can not,
> which is why I do this.

HI Fengguang,
I have a question for you. My build system is mostly based on your
make.cross file, which I have modified again to suit my build system in
travis-ci. But for some arch the compilers used by make.cross are really
old and it generated gcc bug while compiling. I faced them for two arch
in recent past. Current one is for cris. I was ablr to find out which
commit was responsible for that build fail but since its old gcc version
no one is interested. How do you handle that? Is there no way to get the
latest compilers to test with?

regards
sudip

Re: [PATCH 2/2] mfd: rtsx: fix build warning

[Lee Jones]

On Wed, 07 Oct 2015, Sudip Mukherjee wrote:

> We were getting build warning about unused variable 'err'.
> The commit a3c29b099829 has removed the use of err but missed removing
> the variable which is unused now.
> 
> Fixes: a3c29b099829 ("mfd: rtsx: Simplify function return logic")
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/mfd/rtsx_pcr.c | 2 --
>  1 file changed, 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index b98cf1d..d63f3a8 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
>  
>  static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
>  {
> -	int err;
> -
>  	rtsx_pci_init_cmd(pcr);
>  
>  	while (*tbl & 0xFFFF0000) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/2] mfd: lm3533: fix build warning

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

Hi Sudip,

[auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]

config: x86_64-randconfig-x002-201540 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
>> drivers/mfd/lm3533-core.c:615:2: error: 'ret' undeclared (first use in this function)
     ret = lm3533_device_init(lm3533);
     ^
   drivers/mfd/lm3533-core.c:615:2: note: each undeclared identifier is reported only once for each function it appears in

vim +/ret +615 drivers/mfd/lm3533-core.c

fa648e51 Johan Hovold 2012-05-15  609  	if (IS_ERR(lm3533->regmap))
fa648e51 Johan Hovold 2012-05-15  610  		return PTR_ERR(lm3533->regmap);
16c5c023 Johan Hovold 2012-05-03  611  
16c5c023 Johan Hovold 2012-05-03  612  	lm3533->dev = &i2c->dev;
16c5c023 Johan Hovold 2012-05-03  613  	lm3533->irq = i2c->irq;
16c5c023 Johan Hovold 2012-05-03  614  
16c5c023 Johan Hovold 2012-05-03 @615  	ret = lm3533_device_init(lm3533);
16c5c023 Johan Hovold 2012-05-03  616  	if (ret)
fa648e51 Johan Hovold 2012-05-15  617  		return ret;
16c5c023 Johan Hovold 2012-05-03  618  

:::::: The code at line 615 was first introduced by commit
:::::: 16c5c023aac86228e3e94c4bf6d19708ea861a05 mfd: Add LM3533 lighting-power core driver

:::::: TO: Johan Hovold <jhovold@gmail.com>
:::::: CC: Samuel Ortiz <sameo@linux.intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 22104 bytes --]

Re: [PATCH 1/2] mfd: lm3533: fix build warning

[Lee Jones]

On Wed, 07 Oct 2015, Sudip Mukherjee wrote:

> We were getting build warning about unused variable 'ret'.
> The commit c749db571dcf has removed the use of ret but missed removing
> the variable which is unused now.
> 
> Fixes: c749db571dcf ("mfd: lm3533: Simplify function return logic")
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/mfd/lm3533-core.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 193ecee1..5abcbb2 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
>  					const struct i2c_device_id *id)
>  {
>  	struct lm3533 *lm3533;
> -	int ret;
>  
>  	dev_dbg(&i2c->dev, "%s\n", __func__);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog