From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752367AbbJGM5O (ORCPT ); Wed, 7 Oct 2015 08:57:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33182 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbbJGM5N (ORCPT ); Wed, 7 Oct 2015 08:57:13 -0400 Date: Wed, 7 Oct 2015 13:56:12 +0100 From: Greg KH To: Srinivas Kandagatla Cc: maxime.ripard@free-electrons.com, linux-kernel@vger.kernel.org, andrew@lunn.ch, wxt@rock-chips.com, stefan.wahren@i2se.com, pantelis.antoniou@konsulko.com, maitysanchayan@gmail.com, p.zabel@pengutronix.de, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] nvmem: core: set the size for the nvmem binary file. Message-ID: <20151007125612.GB7962@kroah.com> References: <1444215536-10783-1-git-send-email-srinivas.kandagatla@linaro.org> <1444215655-10878-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444215655-10878-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 12:00:55PM +0100, Srinivas Kandagatla wrote: > This patch sets the actual size of binary file to the nvmem size. > Previously this was not possible as the core was using the static global > data structures for attributes. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/nvmem/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 0a70e31..737fa75 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -315,6 +315,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) > if (!nvmem->read_only) > nvmem->bin.attr.mode |= S_IWUSR; > > + nvmem->bin.size = nvmem->size; Why does the size matter? What userspace tool needs to know this? thanks, greg k-h