From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754917AbbJGQYd (ORCPT ); Wed, 7 Oct 2015 12:24:33 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:47726 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754151AbbJGQYc (ORCPT ); Wed, 7 Oct 2015 12:24:32 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 7 Oct 2015 09:24:27 -0700 From: "Paul E. McKenney" To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 09/18] rcu: Switch synchronize_sched_expedited() to IPI Message-ID: <20151007162427.GO3910@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20151006162907.GA12020@linux.vnet.ibm.com> <1444148977-14108-1-git-send-email-paulmck@linux.vnet.ibm.com> <1444148977-14108-9-git-send-email-paulmck@linux.vnet.ibm.com> <20151007141807.GD3604@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151007141807.GD3604@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15100716-0017-0000-0000-00000E74B0DB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 04:18:07PM +0200, Peter Zijlstra wrote: > On Tue, Oct 06, 2015 at 09:29:28AM -0700, Paul E. McKenney wrote: > > > @@ -161,6 +161,8 @@ static void rcu_cleanup_dead_rnp(struct rcu_node *rnp_leaf); > > static void rcu_boost_kthread_setaffinity(struct rcu_node *rnp, int outgoingcpu); > > static void invoke_rcu_core(void); > > static void invoke_rcu_callbacks(struct rcu_state *rsp, struct rcu_data *rdp); > > +static void __maybe_unused rcu_report_exp_rdp(struct rcu_state *rsp, > > + struct rcu_data *rdp, bool wake); > > > > Do we really need that on a declaration? I though only unused > definitions required it. You are right. I should have removed it in commit 4684e21b19e9 ("rcu: Switch synchronize_sched_expedited() to IPI"), fixed. Thanx, Paul