From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932188AbbJGWIn (ORCPT ); Wed, 7 Oct 2015 18:08:43 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:35433 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932122AbbJGWIk (ORCPT ); Wed, 7 Oct 2015 18:08:40 -0400 Date: Wed, 7 Oct 2015 15:08:07 -0700 From: Olof Johansson To: Greg KH Cc: Emilio L?pez , kgene@kernel.org, k.kozlowski@samsung.com, linux@roeck-us.net, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 1/4] sysfs: Support is_visible() on binary attributes Message-ID: <20151007220807.GA3375@localhost> References: <1442842703-5309-1-git-send-email-emilio.lopez@collabora.co.uk> <1442842703-5309-2-git-send-email-emilio.lopez@collabora.co.uk> <20151004183334.GA23538@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151004183334.GA23538@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 04, 2015 at 07:33:34PM +0100, Greg KH wrote: > On Mon, Sep 21, 2015 at 10:38:20AM -0300, Emilio L?pez wrote: > > According to the sysfs header file: > > > > "The returned value will replace static permissions defined in > > struct attribute or struct bin_attribute." > > > > but this isn't the case, as is_visible is only called on struct attribute > > only. This patch introduces a new is_bin_visible() function to implement > > the same functionality for binary attributes, and updates documentation > > accordingly. > > > > Note that to keep functionality and code similar to that of normal > > attributes, the mode is now checked as well to ensure it contains only > > read/write permissions or SYSFS_PREALLOC. > > > > Reviewed-by: Guenter Roeck > > Signed-off-by: Emilio L?pez > > As this should probably go through the "platform drivers" maintainer, > I'll just give you this: > > Acked-by: Greg Kroah-Hartman > > So it can go through their tree and not require me to just take this > one. Thanks, applied to the chrome-platform tree now. -Olof