From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300AbbJHHTh (ORCPT ); Thu, 8 Oct 2015 03:19:37 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:33110 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbbJHHTg (ORCPT ); Thu, 8 Oct 2015 03:19:36 -0400 Date: Thu, 8 Oct 2015 08:19:32 +0100 From: Lee Jones To: Ben Hutchings Cc: Maxim Levitsky , Roger Tseng , LKML Subject: Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop Message-ID: <20151008071932.GI17172@x1> References: <1443400461.2517.22.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443400461.2517.22.camel@decadent.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Sep 2015, Ben Hutchings wrote: > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > uninterruptible sleep still contribute to the load average (for > bug-compatibility with Unix). A load average of ~1 on a system that > should be idle is somewhat alarming. > > Change the sleep to be interruptible, but still ignore signals. > > A better fix might be to replace this loop with a delayed work item. > > References: https://bugs.debian.org/765717 > Signed-off-by: Ben Hutchings Any chance you can use Git instead of Quilt? Failing that, is there a way to tell Quilt to supply a diffstat in the patch? > --- > --- a/drivers/memstick/host/rtsx_usb_ms.c > +++ b/drivers/memstick/host/rtsx_usb_ms.c > @@ -706,7 +706,8 @@ poll_again: > if (host->eject) > break; > > - msleep(1000); > + if (msleep_interruptible(1000)) > + flush_signals(current); > } > > complete(&host->detect_ms_exit); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog