From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755134AbbJHI7b (ORCPT ); Thu, 8 Oct 2015 04:59:31 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:47419 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754992AbbJHI72 (ORCPT ); Thu, 8 Oct 2015 04:59:28 -0400 Date: Thu, 8 Oct 2015 10:59:16 +0200 From: Peter Zijlstra To: luto@kernel.org, hpa@zytor.com, bp@alien8.de, mingo@kernel.org, brgerst@gmail.com, luto@amacapital.net, torvalds@linux-foundation.org, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/asm] x86/entry, locking/lockdep: Move lockdep_sys_exit() to prepare_exit_to_usermode() Message-ID: <20151008085916.GG3604@twins.programming.kicks-ass.net> References: <1736ebe948b845e68120b86b89091f3ec27f5e8e.1444091584.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 09:17:44AM -0700, tip-bot for Andy Lutomirski wrote: > Commit-ID: 72f924783b8a87e4454516520ffb5f35e4930371 > Gitweb: http://git.kernel.org/tip/72f924783b8a87e4454516520ffb5f35e4930371 > Author: Andy Lutomirski > AuthorDate: Mon, 5 Oct 2015 17:47:54 -0700 > Committer: Ingo Molnar > CommitDate: Wed, 7 Oct 2015 11:34:07 +0200 > > x86/entry, locking/lockdep: Move lockdep_sys_exit() to prepare_exit_to_usermode() > > Rather than worrying about exactly where LOCKDEP_SYS_EXIT should > go in the asm code, add it to prepare_exit_from_usermode() and > remove all of the asm calls that are followed by > prepare_exit_to_usermode(). > > LOCKDEP_SYS_EXIT now appears only in the syscall fast paths. Does that not pose a risk that something that always takes the slow path (signals? tracing?) will leak a lock to userspace?