From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932369AbbJHMjI (ORCPT ); Thu, 8 Oct 2015 08:39:08 -0400 Received: from m12-18.163.com ([220.181.12.18]:60162 "EHLO m12-18.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbbJHMjE (ORCPT ); Thu, 8 Oct 2015 08:39:04 -0400 Date: Thu, 8 Oct 2015 20:29:46 +0800 From: Yaowei Bai To: Boaz Harrosh Cc: viro@zeniv.linux.org.uk, bhalevy@primarydata.com, osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid_dev check Message-ID: <20151008122946.GB3711@bbox> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> <1443447836-5178-1-git-send-email-bywxiaobai@163.com> <560A9672.9@electrozaur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560A9672.9@electrozaur.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CM-TRANSID: EsCowEDZH1a6YRZWaL_ZBQ--.2977S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xr1ruF17Gr18GrWUtFWfAFb_yoWkurc_Wr Wjyw48Zr15Xw1xAan5Kw15Xr9Y9Fs0grW8J343tr43XFn3tFZ5ZaykWws5AFy7uF48GFZx uryF9a45Gr1j9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnJ8nUUUUUU== X-Originating-IP: [58.208.67.211] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiLRyNT1SIKo3+qgAAsc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 04:47:30PM +0300, Boaz Harrosh wrote: > On 09/28/2015 04:43 PM, Yaowei Bai wrote: > > As new_valid_dev always returns 1, so !new_valid_dev check is not > > needed, remove it. > > > > Signed-off-by: Yaowei Bai > > ACK-by: Boaz Harrosh > > Please submit this through some General tree like the vfs or mm-tree Sorry for delay reply. There's something wrong with my mailbox and i lost your last recent reply. And i just want to say i will follow your advice to send this patchset to Morton and once he takes it i'll send another patch to remove new_valid_dev() at all. Thanks. Thanks Bai > > Thanks > Boaz > > > --- > > fs/exofs/namei.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c > > index 09a6bb1..994e078 100644 > > --- a/fs/exofs/namei.c > > +++ b/fs/exofs/namei.c > > @@ -80,9 +80,6 @@ static int exofs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, > > struct inode *inode; > > int err; > > > > - if (!new_valid_dev(rdev)) > > - return -EINVAL; > > - > > inode = exofs_new_inode(dir, mode); > > err = PTR_ERR(inode); > > if (!IS_ERR(inode)) { > >