From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932998AbbJHNwg (ORCPT ); Thu, 8 Oct 2015 09:52:36 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33272 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932877AbbJHNwd (ORCPT ); Thu, 8 Oct 2015 09:52:33 -0400 Date: Thu, 8 Oct 2015 19:22:28 +0530 From: Viresh Kumar To: "Jon Medhurst (Tixy)" Cc: Sudeep Holla , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: arm_big_little: fix frequency check when bL switcher is active Message-ID: <20151008135228.GG18898@linux> References: <1443807532.2845.25.camel@linaro.org> <20151007173920.GG4557@linux> <1444296229.2847.9.camel@linaro.org> <20151008112454.GE18898@linux> <1444308924.2847.35.camel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444308924.2847.35.camel@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-10-15, 13:55, Jon Medhurst (Tixy) wrote: > Looking a bit more carefully, the reason your fix doesn't work is that > bL_cpufreq_get_rate returns the last requested rate for this CPU, > whereas target_rate/new_rate is the maximum rate requested by any CPU on > the cluster (which is what we want the hardware set to). Sigh.. > So sounds like my alternative fix of checking the 'actual' frequency > immediately after setting it is probably the way forward, unless Sudeep > chimes in with additional info about the issue he was trying to address. Right. -- viresh