From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932663AbbJHOO7 (ORCPT ); Thu, 8 Oct 2015 10:14:59 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36452 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932433AbbJHOOy (ORCPT ); Thu, 8 Oct 2015 10:14:54 -0400 Date: Thu, 8 Oct 2015 16:14:49 +0200 From: Ingo Molnar To: Borislav Petkov Cc: Andy Lutomirski , Andy Lutomirski , X86 ML , "linux-kernel@vger.kernel.org" , Brian Gerst , Denys Vlasenko , Linus Torvalds Subject: Re: [PATCH v2 09/36] x86/asm: Re-add manual CFI infrastructure Message-ID: <20151008141449.GA29358@gmail.com> References: <4c70bb98a8b773c8ccfaabf6745e569ff43e7f65.1444091584.git.luto@kernel.org> <20151006082305.GB18287@gmail.com> <20151008131142.GB459@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151008131142.GB459@nazgul.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > On Tue, Oct 06, 2015 at 11:21:41AM -0700, Andy Lutomirski wrote: > > > OK, I'll strip out the push, movq, etc stuff for v3. I'll leave all of the > > CFI_XYZ macros, even the unused one, because that's only a couple of lines of > > code and they all have very simple and obvious meanings (or as simple as the > > underlying directives, anyway). > > If they're going to be used by the vDSO only, maybe they all should go into a > header which is private to the vDSO only so that people don't get any ideas and > the gunk starts spreading again... Yeah. So for the vDSO code itself it's an obvious step forward: replacing black magic hexa encodings with symbolic directives. Thanks, Ingo