From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933809AbbJHQku (ORCPT ); Thu, 8 Oct 2015 12:40:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48305 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933103AbbJHQks (ORCPT ); Thu, 8 Oct 2015 12:40:48 -0400 Date: Thu, 8 Oct 2015 12:23:16 -0400 From: Greg KH To: Pavel Machek Cc: Tim Bird , Baolin Wang , "patches@opensource.wolfsonmicro.com" , "sameo@linux.intel.com" , "linux-pm@vger.kernel.org" , Dmitry Eremin-Solenikov , David Woodhouse , "linux-usb@vger.kernel.org" , "r.baldyga@samsung.com" , "sojka@merica.cz" , Felipe Balbi , LKML , Alan Stern , Peter Chen , "sre@kernel.org" , Lee Jones , "device-mainlining@lists.linuxfoundation.org" , "yoshihiro.shimoda.uh@renesas.com" Subject: Re: [Device-mainlining] [PATCH v2 2/3] gadget: Introduce the usb charger framework Message-ID: <20151008162316.GA5833@kroah.com> References: <0c41e21239f69c4e1aa89aba020c91edfc17c4e8.1439519413.git.baolin.wang@linaro.org> <20150814152723.GA17892@kroah.com> <55D1FCDF.6060709@sonymobile.com> <20151008155031.GE11776@xo-6d-61-c0.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151008155031.GE11776@xo-6d-61-c0.localdomain> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2015 at 05:50:31PM +0200, Pavel Machek wrote: > Hi! > > > On 08/16/2015 08:03 PM, Baolin Wang via device-mainlining wrote: > > > On 14 August 2015 at 23:27, Greg KH wrote: > > >> On Fri, Aug 14, 2015 at 05:47:45PM +0800, Baolin Wang wrote: > > >>> + * > > >>> + * This program is free software; you can redistribute it and/or modify > > >>> + * it under the terms of the GNU General Public License as published by > > >>> + * the Free Software Foundation; either version 2 of the License, or > > >>> + * (at your option) any later version. > > >> > > >> I have to ask, do you really mean "any later version"? > > >> > > > > > > I think I did not get your point, could you explain it detailedly? > > > > The full kernel is licensed under v2 of the GPL only, not "any later version". > > See the second paragraph at the top of the COPYING file in the root directory > > of the kernel source tree. There are differences on individual files, but > > having this file allow "any later version" makes it different from much of > > rest of the kernel. > > > > Unless you have a specific reason to allow greater-than-V2 GPL licensing on this > > file, you should change the licensing clause. The following wording appears > > to be pretty popular: > > > > * This program is free software; you can redistribute it and/or modify > > * it under the terms of the GNU General Public License version 2 as > > * published by the Free Software Foundation. > > Please, keep it V2 or later, if you can. It makes sharing code with U-Boot (for > example) easier. > > There's long tradition of "V2 or later" code in the kernel. And there's even longer "v2 only" tradition as well. It's up to the person / company submitting the code to pick the license for it, let them make the decision please. thanks, greg k-h