From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757644AbbJHSBW (ORCPT ); Thu, 8 Oct 2015 14:01:22 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:53606 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbbJHSBV (ORCPT ); Thu, 8 Oct 2015 14:01:21 -0400 Date: Thu, 8 Oct 2015 11:01:14 -0700 From: Josh Triplett To: "Paul E. McKenney" Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 18/18] rcu: Better hotplug handling for synchronize_sched_expedited() Message-ID: <20151008180114.GA2814@cloud> References: <20151006162907.GA12020@linux.vnet.ibm.com> <1444148977-14108-1-git-send-email-paulmck@linux.vnet.ibm.com> <1444148977-14108-18-git-send-email-paulmck@linux.vnet.ibm.com> <20151007142627.GE3604@twins.programming.kicks-ass.net> <20151007162653.GP3910@linux.vnet.ibm.com> <20151008090128.GI3604@twins.programming.kicks-ass.net> <20151008150639.GA3910@linux.vnet.ibm.com> <20151008151242.GQ3816@twins.programming.kicks-ass.net> <20151008151903.GB3910@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151008151903.GB3910@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2015 at 08:19:03AM -0700, Paul E. McKenney wrote: > On Thu, Oct 08, 2015 at 05:12:42PM +0200, Peter Zijlstra wrote: > > On Thu, Oct 08, 2015 at 08:06:39AM -0700, Paul E. McKenney wrote: > > > Please see below for the fixed version. Thoughts? > > > > > + __releases(rnp->lock) /* But leaves rrupts disabled. */ > > > + raw_spin_unlock(&rnp->lock); /* rrupts remain disabled. */ > > > + raw_spin_lock(&rnp->lock); /* rrupts already disabled. */ > > > > What them 'rrupts' about? ;-) > > Interrupts when it won't fit. I suppose I could use IRQs instead. ;-) In this particular case, "IRQs" works just as well; however, in general, this seems like an excellent example of when to ignore the 80-column guideline. :) - Josh Triplett