From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932080AbbJIGkM (ORCPT ); Fri, 9 Oct 2015 02:40:12 -0400 Received: from muru.com ([72.249.23.125]:56858 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754001AbbJIGkK (ORCPT ); Fri, 9 Oct 2015 02:40:10 -0400 Date: Thu, 8 Oct 2015 23:40:06 -0700 From: Tony Lindgren To: Ben Tucker Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP2+: Fixed inverted OMAP_OFFOUT_EN Message-ID: <20151009064005.GA23801@atomide.com> References: <1444308486-16204-1-git-send-email-benjamint@bsquare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444308486-16204-1-git-send-email-benjamint@bsquare.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ben Tucker [151008 06:09]: > The OFFOUTENABLE bit of the omap PADCONF registers is active low. > The mux code assumed that it was active high and this patch fixes this > problem. > > Tested on an AM37x device. Hmm what are the test cases you're using to validate this so I can try to reproduce? AFAIK because of erratum 1.158 for GPIO pins needing to be muxed temporarly for input + pull + safe mode for off mode, so I'm wondering in which cases the OFFOUTENABLE can be used. I have a patch in works for 1.158 using gpio-ranges, and the test case I'm using is the reset of WLAN that happens in off mode as the enable GPIO glitches when returning from off mode. Also.. I'm wondring why this has not been caught earlier? Maybe because 1.158 is needed on omap3? Regrds, Tony