From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755552AbbJIHEB (ORCPT ); Fri, 9 Oct 2015 03:04:01 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57989 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429AbbJIHD7 (ORCPT ); Fri, 9 Oct 2015 03:03:59 -0400 Date: Fri, 9 Oct 2015 00:03:57 -0700 From: Stephen Boyd To: Jon Mason Cc: Michael Turquette , Florian Fainelli , Hauke Mehrtens , Ray Jui , Scott Branden , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH 05/10] clk: iproc: Add PLL base write function Message-ID: <20151009070357.GN26883@codeaurora.org> References: <1443826665-17570-1-git-send-email-jonmason@broadcom.com> <1443826665-17570-6-git-send-email-jonmason@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443826665-17570-6-git-send-email-jonmason@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02, Jon Mason wrote: > diff --git a/drivers/clk/bcm/clk-iproc-pll.c b/drivers/clk/bcm/clk-iproc-pll.c > index e029ab3..a4602aa 100644 > --- a/drivers/clk/bcm/clk-iproc-pll.c > +++ b/drivers/clk/bcm/clk-iproc-pll.c > @@ -137,6 +137,18 @@ static int pll_wait_for_lock(struct iproc_pll *pll) > return -EIO; > } > > +static void iproc_pll_write(struct iproc_pll *pll, void __iomem *base, Seems that pll could be const too? > + u32 offset, u32 val) > +{ > + const struct iproc_pll_ctrl *ctrl = pll->ctrl; > + -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project