From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754593AbbJIJEZ (ORCPT ); Fri, 9 Oct 2015 05:04:25 -0400 Received: from down.free-electrons.com ([37.187.137.238]:53533 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751229AbbJIJEW (ORCPT ); Fri, 9 Oct 2015 05:04:22 -0400 Date: Fri, 9 Oct 2015 11:03:53 +0200 From: Antoine Tenart To: Jisheng Zhang Cc: sebastian.hesselbarth@gmail.com, linus.walleij@linaro.org, antoine.tenart@free-electrons.com, catalin.marinas@arm.com, will.deacon@arm.com, mark.rutland@arm.com, robh+dt@kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/6] pinctrl: berlin: add the berlin4ct pinctrl driver Message-ID: <20151009090353.GA2842@kwain> References: <1444378629-3057-1-git-send-email-jszhang@marvell.com> <1444378629-3057-3-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1444378629-3057-3-git-send-email-jszhang@marvell.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jisheng, On Fri, Oct 09, 2015 at 04:17:05PM +0800, Jisheng Zhang wrote: > diff --git a/drivers/pinctrl/berlin/Kconfig b/drivers/pinctrl/berlin/Kconfig > index b18322b..c13f6d2 100644 > --- a/drivers/pinctrl/berlin/Kconfig > +++ b/drivers/pinctrl/berlin/Kconfig > @@ -17,4 +17,9 @@ config PINCTRL_BERLIN_BG2Q > bool > select PINCTRL_BERLIN > > +config PINCTRL_BERLIN_BG4CT > + depends on OF && (ARCH_BERLIN || COMPILE_TEST) > + bool "Marvell berlin4ct pin controller driver" > + select PINCTRL_BERLIN > + > endif This endif ends the following condition: if ARCH_BERLIN [...] So the "depends on ARCH_BERLIN" here can be dropped. Also the COMPILE_TEST can be moved as it isn't BG4CT specific and all other Berlin pinctrl drivers would benefit from this. So we would have something like: if (ARCH_BERLIN || COMPILE_TEST) [...] endif Finally you can move the OF dependency to the PINCTRL_BERLIN config as all Berlin pinctrl drivers depends on it. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com