From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965293AbbJIJtq (ORCPT ); Fri, 9 Oct 2015 05:49:46 -0400 Received: from mail-bl2on0132.outbound.protection.outlook.com ([65.55.169.132]:52613 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965218AbbJIJth (ORCPT ); Fri, 9 Oct 2015 05:49:37 -0400 X-Greylist: delayed 1075 seconds by postgrey-1.27 at vger.kernel.org; Fri, 09 Oct 2015 05:49:37 EDT Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Date: Fri, 9 Oct 2015 17:15:30 +0800 From: Shengjiu Wang To: Shawn Guo CC: , , , , , , , , , , , , Subject: Re: [PATCH V2 1/2] clk: imx6: Add SPDIF_GCLK clock in clock tree Message-ID: <20151009091528.GA25804@shlinux2> References: <113f1cecf1d83c6b96fd23ab9d7a73d1923e0d21.1442310569.git.shengjiu.wang@freescale.com> <20150923153340.GK3529@tiger> <20150924054321.GA32196@shlinux2> <20150924115737.GM3529@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150924115737.GM3529@tiger> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC001;1:tC3GuFLCRYw4WAzp6e3Y8RfntxBloZ4JxGkiVe+XjrtDSb2FTrhPKJQpUxSuKWozOIMS5BDP9bLL7X+EtUDjhtrRugqMmK/Jy/o2VNJYsZ4YdzJIcYuVYhDsk1YeTfOv5Txdj4Dwx4CUzLAzqj+pmPWE+TppyScRHQKNSz2pCJaLp6NParN/XIo+gg/XQh0It2aCYnuP0Usi6jJcnUBSfyzKcwXwf5DTgkpc4VIB5Un3ESMoa6dpouUTNWKLuXfc6t1xhTsD7X3oLNdiaT2Wol8xkKLyvW8Dh8s38nGiYfm8bEyzBhx6QHV0V4gsVsStIyRZpCDg5Prk7W29rFYnlvmO9g0EroZiJoAKlN+FdhUVhMrxKYwDy19/SoNQ6Mxg X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(24454002)(5007970100001)(50466002)(2950100001)(46102003)(69596002)(33716001)(97756001)(93886004)(33656002)(92566002)(76176999)(46406003)(77096005)(50986999)(11100500001)(81156007)(97736004)(4001350100001)(86362001)(23726002)(5001920100001)(104016004)(6806005)(5008740100001)(110136002)(189998001)(5001960100002)(83506001)(106466001)(85426001)(105606002)(47776003)(64706001)(87936001)(54356999);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1420;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1420;2:pAkwlYivZdtFcZ8cBioCrJTsTAjEvYzQLLEZJxQhGYWcej1oQPkcrxX/myaG2HAzKu6VQrznSRKAPo08UvYhGYv/ZX3TTAdZcTm8XzQ4rpxkC1F7j9I4giOrFftQNc1VnVg5JcHQ7lUAMkGsnHD6yDcMRW39kwGPuKv1RFGeOlM=;3:K6MDHdWdv00ErAPWsty6868Go1pCKEojBIY0ERZDNj9NiYycLskK7g71hGX6NdVsykQDVbisO/YD7cGNHTw9rgn0uww4A309vDrqi1ucnShLmpxaU9OE9NpQKlVF25cy1TzXCrBxb4zrMx0wYP5mbKUo3yZJFC15RNDCKVqXU8HPLDximLVO/NOQ4w7o4CCaeCiUv1SHY3lubH6ki62OQC/zcGGc/00PaeiyoLZfb7A=;25:63xblC80aJkib6RNt36gSjpboQx+SoKhGIRGnScPK64Ib3Y1GdUQfuJGlrcfa6TnHfZxpuPZdRfPkv79RjaPltoqpu8I/VAAUPvmaGCNZXfpou14mAjPqMXeOop6EA+z2lQT7WoFRzuzVR1dpX0Fb6FPcOeOW7bVOUYPCzX92+el+DWBiXBNwFNob1ER2l2TlKrOkJqlaCtPQLu+exrz8VEHPSLFgeXchetDz8pbLbzH2vY5dgV53KEaAwm+uy6fEVfPSh2vlKbV8Sxy8JdcvQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1420; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1420;20:EYw+AFO9s/un1pKZA7IR6VnnZvZxsEmDpxaOsXIoLeZsix2itYPO93aGRTqbB5h2/U1798MgtnJhIWaq87zMWOQuwH+fxRmzkB1FoZgEERorJ78NHVHE59brCkPc/mGWt6N+q9kTGZBZ3X3s6wCaR9XA+YiRuo+q74pbbDlYYAnluVhC6jhLAIJMwjsohkM6rxBzRq7dEosy7psrNpJlPiQvb9M36De6ip5hboO5Ura1POsxV7Rsu2bxjqPiDUcV01UPZpKMzuM/2StRo2EUQmyEKGls9GXBElCXdnZfNNv9k+BFD3un1PhN5/TfeCtq/8YFipHJwSB+ZeY7c69QXvn8jSeEKz/uVlWcWfq9Vwk=;4:C93+I5MjNyJRaAG0w/rViac9V36zY1ubru/o4+PYgdii3AC/C2Q/Kn0REw6Il6V8hXr5p0dlRy6j6fDtHfTKAUTPwB7No9vysK43rf0WyM6FC7D0VeEabWoxZt/beFvOKfU2vhCsB6gGdGHdEsuaSWCp7hqFoongF14gAWn/xihN9CmYW9kpc9ovBaOSGFIhU/6pI+2Kla8mm90NyoaDNuCixJ194c21GkCOsYA7wlZNPQb18kpI8AyjwBvuH6eN/2/MFJ4+OIjABxhRbQX5Oqt6HUFGFlreX9dPZt7eMbnLUeH0e+HQpjYC9PA/41Q+2O6q1pRKCS35ODUzXsl4jaX+zQb1bfMm07savSDfK8s= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:BY1PR03MB1420;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1420; X-Forefront-PRVS: 0724FCD4CD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR03MB1420;23:q1fKNGKi0/5la3iAl/26trOxa08hYN1wdHbFNXEVe?= =?us-ascii?Q?uFgvefQhgT/Mfw746hdWdY6GeY1XixWT64HWTP54FWYok7mx4zMDuG4Zg76h?= =?us-ascii?Q?laIaqOray779YqlvAT0KGh9W/B39b8jZnlNZcsDOH5GHKmnjkWoHadALwDX9?= =?us-ascii?Q?LRFtb8jx/FpuBiHROnvfBY0BUs/2dHgylq0CXWvTzKDAUFHSUkACnvaDfUnS?= =?us-ascii?Q?zVLkxSjheip6XIMg4vHgjCBeMiHTkMMNyjoqwhuoAZw+ZMfdAc5x4hBIps0v?= =?us-ascii?Q?FLcoWMq7YOdlIygwb7TjhwJwXqQnmR/rMkbAdAP8ch25qSKfTM7KPsHU/eby?= =?us-ascii?Q?QrsgleXBERe0z+pbb7uH8TTjufOvNq0Oo0+mJt6z3ZzuI8TQdtf4AmLjxckP?= =?us-ascii?Q?DPvaSuzr7GU4X9+CaDsjbVV367nJp7CScwKqJbnrFkmNw1BZhP26qI9Am+fa?= =?us-ascii?Q?K0WHqlSC+Zfw2QtOvbPUjjuXe754xu8aQxKza54vsHl/6B484oX4gOCr4Urr?= =?us-ascii?Q?gEhZw5Y4y8z7VzxmenLeZpoO+IUk+EAoqb7bYbOp4abI/JWVz2nuf/lXhCNq?= =?us-ascii?Q?O2TKs13SLmW1E3lM0/XxWGZj28JrYHs91Pk6NFQqWvqnwMGgqh33L+EcXaUK?= =?us-ascii?Q?QlWVQ3hk2KbDPuruk2wVxXfdzV4lPEkKYpa7B+XrTncHrWXzo7FVIFq1DAwT?= =?us-ascii?Q?52vW6pGrcfMe6yB6FfmZggIxeoHOE3tCeE+co6am7SFKRmOXvmKaz2Wg5rNY?= =?us-ascii?Q?djrdS2Kkb+W3tNTlUaC2h3Uk1D1gB8uLRBgBc2+rb8dQ/N5Y+ClX3mV51SFv?= =?us-ascii?Q?Lm2SJi2KMxdkws3cwKs8WuneT1bcH7VDfxsYM6aryYNRSYTWI9NXo8SaFUN/?= =?us-ascii?Q?cZHrDVOHYrlTrm+IkMHmSVse3xVl9D5lri9WHNh+KiwmGq8gExYhcBFb4T/M?= =?us-ascii?Q?N+zWm+Nw/xQssgvgr43fSmmr5KYNEqM9yaStYqoOIaHlCRndQEkVYujnDf/a?= =?us-ascii?Q?BiRjak1TAsS2QOyAmTcHISDL378QMHkUy8MQoCMhIJ4mT9K/YkPJuuvLyq6+?= =?us-ascii?Q?TYb1/4rH+m1RB+SLe+UkELQg8UOvclGlTSq0EHuzxoL4ncY3TiRSzHgQpyzw?= =?us-ascii?Q?Y8k9Fh7hLJJKPqt6/FyQTxwqOu1LdJj?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1420;5:ERSCITdMJjLZbA4JYeeLTjbmQ+yBNT83Bb94/oQ9Q2s22s8WzbmLtTzT4jdRkpN2SjmvUElewxU6dta6B7frC3n/yOxd3r6VINfgS1MQBmqHXqXJCpt5JTuOMaESzSNoux2vQkoq0M5RAk1Ni6v4tA==;24:gsdbmAoS0FAmaSsfCyFvxEbnyUoHd4NBEONvomHvCOedsknFxaQrSAnze9I/9aMrUA6MLIYesVsDoXFTs/evibOhwlcGmLNRnc5hGD8t3hM=;20:Pg75BdFKfcuz2fpopzp6EwBcszzhPRLEnvsFy5aNfuGB4hFR15sfj68J6ustHkTun7ssA7XFRRwlj1T7rdNVOQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2015 09:16:12.0819 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1420 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 04:57:37AM -0700, Shawn Guo wrote: > On Thu, Sep 24, 2015 at 01:43:24PM +0800, Shengjiu Wang wrote: > > On Wed, Sep 23, 2015 at 08:33:41AM -0700, Shawn Guo wrote: > > > On Tue, Sep 15, 2015 at 06:01:01PM +0800, Shengjiu Wang wrote: > > > > As spdif driver will register SPDIF clock to regmap, regmap will do > > > > clk_prepare in init function, so SPDIF clock is prepared in probe, then its > > > > root clock (pll clock) is prepared also, which cause the arm can't enter > > > > low power mode. > > > > > > Can you help me understand why ARM cannot enter low power mode when pll > > > clock is prepared? > > > > > > Shawn > > Hi Shawn > > > > In i.mx clock framework, when pll clk is prepared, it will be powerup. when > > enterring low power idle mode, the powerdown bit is checked, when pll is not > > powerdown state, chip will not enter low power idle mode. > > So this is not a SPDIF specific problem, and any device driver preparing > its clock that is a child of pll clock will run into this problem, > right? If so, we should purchase a more generic solution than such > device specific one. > > Shawn Hi shawn SPDIF_GCLK is also spdif's clock, it use a same enable bit with SPDIF_ROOT_CLK, We didn't separate them in clock tree before. I can't find a generic solution. But anyway if there is a solution or not, I think we'd better to separate them. best regards wang shengjiu