From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756027AbbJINez (ORCPT ); Fri, 9 Oct 2015 09:34:55 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:33906 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752481AbbJINex (ORCPT ); Fri, 9 Oct 2015 09:34:53 -0400 Date: Fri, 9 Oct 2015 16:34:50 +0300 From: "Kirill A. Shutemov" To: Vineet Gupta Cc: Andrew Morton , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code Message-ID: <20151009133450.GA8597@node> References: <1444391029-25332-1-git-send-email-vgupta@synopsys.com> <5617BB4A.4040704@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5617BB4A.4040704@synopsys.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2015 at 06:34:10PM +0530, Vineet Gupta wrote: > On Friday 09 October 2015 05:13 PM, Vineet Gupta wrote: > > - pgtable-generic.c: Fold individual #ifdef for each helper into a top > > level #ifdef. Makes code more readable > > > > - Converted the stub helpers for !THP to BUILD_BUG() vs. runtime BUG() > > > > Signed-off-by: Vineet Gupta > > Sorry for sounding pushy - an Ack here will unblock me from dumping boat load of > patches into linux-next via my tree ! I hope you've tested it with different .configs... Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov