From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752801AbbJIMH1 (ORCPT ); Fri, 9 Oct 2015 08:07:27 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:34264 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbbJIMHZ (ORCPT ); Fri, 9 Oct 2015 08:07:25 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-dd-5617adfb66b7 Date: Fri, 09 Oct 2015 14:07:16 +0200 From: Lukasz Majewski To: Krzysztof Kozlowski Cc: Sudip Mukherjee , Zhang Rui , Eduardo Valentin , Kukjin Kim , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] thermal: exynos: fix register read in TMU Message-id: <20151009140716.0c6e57b7@amdc2363> In-reply-to: References: <1443699599-9693-1-git-send-email-sudipm.mukherjee@gmail.com> <20151001141243.GA5061@sudip-pc> <20151008142129.GC10587@sudip-pc> Organization: SPRC Poland X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRmVeSWpSXmKPExsVy+t9jQd3fa8XDDDonClvMv3KN1eL1C0OL /sevmS02PQbyLu+aw2bxufcIo8WM8/uYLJ487GOzOHB6CrMDp8fOWXfZPRbvecnksWlVJ5vH 5iX1Hn1bVjF6fN4kF8AWxWWTkpqTWZZapG+XwJVxve84Y0GvYMXORzMZGxiX8XYxcnJICJhI LDu7mwnCFpO4cG89WxcjF4eQwCxGidndb1khnDeMEhM+/QOq4uBgEVCV6HwdCtLAJqAn8fnu U7BmEQFDiYO7tzOB1DMLLGSSWHHyJytIQljATuLShWZGEJsXqOHa57/sIDanQLBE6/IGdogF T5kklj95A5bgF5CUaP/3gxniJDuJc582sEM0C0r8mHyPBcRmFtCS2LytiRXClpfYvOYt8wRG wVlIymYhKZuFpGwBI/MqRonUguSC4qT0XMO81HK94sTc4tK8dL3k/NxNjOAIeSa1g/HgLvdD jAIcjEo8vBZR4mFCrIllxZW5hxglOJiVRHgv1QGFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8944 xBAmJJCeWJKanZpakFoEk2Xi4JRqYHSNrbY4c9lnKVP9oT+9+0Vr65Xys06dWTrpxZRT8zTv Zt47YJ1Wlc0lc+eh3fbu4+sY7G+8bDo4Mb/I8Cj/bION5teuhqx+tvPIXmuud1/MXf6ETTx+ WnrO5z5G4ZCs7LjiaZuddPfqVnj4SH2wCmJcGOjvPiNiguqJANclD4K+dGxQ2PAlMV6JpTgj 0VCLuag4EQD/Fl1zjAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, > 2015-10-08 23:21 GMT+09:00 Sudip Mukherjee > : > > On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote: > >> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee > >> : > >> > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski > >> > wrote: > >> >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee > >> >> : > >> >> > The value of emul_con was getting overwritten if the selected > >> >> > soc is SOC_ARCH_EXYNOS5260. And so as a result we were > >> >> > reading from the wrong register in the case of > >> >> > SOC_ARCH_EXYNOS5260. > >> >> > >> >> How the value is overwritten if the soc is Exynos5260? I can't > >> >> see it (although the "else if" is still more obvious than "if" > >> >> but how does the description match the code?). > >> > The code here is: > >> > if (data->soc == SOC_ARCH_EXYNOS5260) > >> > emul_con = EXYNOS5260_EMUL_CON; > >> > if (data->soc == SOC_ARCH_EXYNOS5433) > >> > emul_con = EXYNOS5433_TMU_EMUL_CON; > >> > else if (data->soc == SOC_ARCH_EXYNOS7) > >> > emul_con = EXYNOS7_TMU_REG_EMUL_CON; > >> > else > >> > emul_con = EXYNOS_EMUL_CON; > >> > > >> > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes > >> > EXYNOS5260_EMUL_CON. But again for the else part it will become > >> > EXYNOS_EMUL_CON. > >> > >> Indeed! > >> > >> Fixes: 488c7455d74c ("thermal: exynos: Add the support for > >> Exynos5433 TMU") > >> > >> Reviewed-by: Krzysztof Kozlowski > > > > Hi Krzysztof, > > Who will pick this one up? I still do not see it in linux-next. > > Hi! > > I guess it is a patch for Lukasz. > > Lukasz, > Do you plan to pick it up or maybe this should go through samsung-soc > tree? This is the only one patch, which is waiting in my queue. Since no more fixes available, please feel free to grab this patch to samsung-soc. Acked-by: Lukasz Majewski > > Best regards, > Krzysztof -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group