From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755645AbbJIOZC (ORCPT <rfc822;w@1wt.eu>);
	Fri, 9 Oct 2015 10:25:02 -0400
Received: from mail-io0-f180.google.com ([209.85.223.180]:34215 "EHLO
	mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752657AbbJIOY7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 9 Oct 2015 10:24:59 -0400
Date: Fri, 9 Oct 2015 09:24:51 -0500
From: Michael Welling <mwelling@ieee.org>
To: Mark Brown <broonie@kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Fionn Cleary <clearyf@tcd.ie>,
        Wolfram Sang <wsa@the-dreams.de>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Sebastian Reichel <sre@kernel.org>
Subject: Re: [RFC PATCH] spi: omap2-mcspi: disable other channels
 CHCONF_FORCE in prepare_message
Message-ID: <20151009142451.GA25376@deathstar>
References: <5616816C.9020904@baylibre.com>
 <20151008152105.GA13157@deathstar>
 <20151009113810.GD1542@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151009113810.GD1542@sirena.org.uk>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 09, 2015 at 12:38:10PM +0100, Mark Brown wrote:
> On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote:
> > On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote:
> 
> > What is the point of doing this void cast below?
> > Avoiding compiler warning perhaps?
> > Perhaps you can __maybe_unused for the variable instead?
> 
> > > +	/* Ignore message */
> > > +	(void)msg;
> 
> You shouldn't need it at all, but yes if there is a good reason to mark
> something as unused the above annotation is better.

Which one?