From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758790AbbJIS1s (ORCPT ); Fri, 9 Oct 2015 14:27:48 -0400 Received: from sauhun.de ([89.238.76.85]:52983 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756634AbbJIS1q (ORCPT ); Fri, 9 Oct 2015 14:27:46 -0400 Date: Fri, 9 Oct 2015 19:27:29 +0100 From: Wolfram Sang To: linux-sh@vger.kernel.org Cc: Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] spi: spi-coldfire-qspi: enable RuntimePM before registering to the core Message-ID: <20151009182729.GA1544@katana> References: <1444383567-18113-1-git-send-email-wsa@the-dreams.de> <1444383567-18113-4-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V" Content-Disposition: inline In-Reply-To: <1444383567-18113-4-git-send-email-wsa@the-dreams.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 09, 2015 at 10:39:27AM +0100, Wolfram Sang wrote: > From: Wolfram Sang >=20 > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, other= wise > this will fail. >=20 > Signed-off-by: Wolfram Sang V2 adds disabling runtime_pm in the error path. There are no dependencies. Patches 1-3 do the same for I2C drivers. I generated this series from a branch and sent out as is; probably I should have sent the SPI one individually. Thanks, Wolfram > --- > drivers/spi/spi-coldfire-qspi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-q= spi.c > index 688956ff5095c2..23f6fffd75e111 100644 > --- a/drivers/spi/spi-coldfire-qspi.c > +++ b/drivers/spi/spi-coldfire-qspi.c > @@ -420,19 +420,20 @@ static int mcfqspi_probe(struct platform_device *pd= ev) > master->auto_runtime_pm =3D true; > =20 > platform_set_drvdata(pdev, master); > + pm_runtime_enable(&pdev->dev); > =20 > status =3D devm_spi_register_master(&pdev->dev, master); > if (status) { > dev_dbg(&pdev->dev, "spi_register_master failed\n"); > goto fail2; > } > - pm_runtime_enable(&pdev->dev); > =20 > dev_info(&pdev->dev, "Coldfire QSPI bus driver\n"); > =20 > return 0; > =20 > fail2: > + pm_runtime_disable(&pdev->dev); > mcfqspi_cs_teardown(mcfqspi); > fail1: > clk_disable(mcfqspi->clk); > --=20 > 2.1.4 >=20 --xHFwDpU9dbj6ez1V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWGAcQAAoJEBQN5MwUoCm2MXIQAJCong40bv32EU0OI42lSCrL 8jpG2LE+p/ve5ABKEmsJkiwx22Uy46AAIqiyel0NqKb++uyIFdjNRldjd4iEAudg QCql8R8iHQw/zOl8jwmL5ic7sNY36gteQnbqI3bfSTv+CEqstOLD2BMZYDYIbyhU TOobxm8sLpywhRDk7bKRG2NqVj60DMFcBE6wH6nJ67iw6RNwloRiJmgYr4D+gS4V 2TL/rB9KV/GzX67mYuIw5tAA2wkTniC5h51t/Bvr88z7vSk4J0bo9okU3bCTK9yo fRcE22rFu0uYaBrBL3w+WKZg6KiZ2wGHsoVIYh0zMFEQqhmCSZjzXMjCeuVzb7zw p0gTJrLY2oOmTrtvvvpsk1gp/l1ylqCu19JLpkIC0lhPG6Qe4BB4cEF9gUFwat0T IXIOI+gH84X7UzG2DeVGotgZdxelTcSnGm3RLtaeR/llvl7VZQm+BrXPrtXXcKhy OqMsFvQ0YyYOKaWX915V+WCjTJ6wzQ9/JErFt0HTKNZ4D4oZ/8d2eKWtdWqWnW+l bdPbDg+DOdJS/gM68TxvMcck8fZz+Qa+oNok28wNMijKdbXciwEtv/Vhwnwialr5 FgMjSviuueKLBW+73GK1PbpzLBnJvQFSp/yyO1GKwViAkqv3FaXQqtkzhbvGIzMm +yWCZrrrM0hcRO+KMgTA =2t4r -----END PGP SIGNATURE----- --xHFwDpU9dbj6ez1V--