From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751343AbbJJBqr (ORCPT ); Fri, 9 Oct 2015 21:46:47 -0400 Received: from mail-by2on0138.outbound.protection.outlook.com ([207.46.100.138]:22468 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751128AbbJJBqm (ORCPT ); Fri, 9 Oct 2015 21:46:42 -0400 X-Greylist: delayed 59424 seconds by postgrey-1.27 at vger.kernel.org; Fri, 09 Oct 2015 21:46:41 EDT Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=none action=none header.from=freescale.com; Date: Sat, 10 Oct 2015 09:45:54 +0800 From: Shengjiu Wang To: Shawn Guo CC: , , , , , , , , , , , , Subject: Re: [PATCH V2 1/2] clk: imx6: Add SPDIF_GCLK clock in clock tree Message-ID: <20151010014553.GB25804@shlinux2> References: <113f1cecf1d83c6b96fd23ab9d7a73d1923e0d21.1442310569.git.shengjiu.wang@freescale.com> <20150923153340.GK3529@tiger> <20150924054321.GA32196@shlinux2> <20150924115737.GM3529@tiger> <20151009091528.GA25804@shlinux2> <20151010011155.GH22673@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151010011155.GH22673@tiger> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD003;1:oJD/hZVzln955LUH+VS5if6DGg7JeHbAg8sIiClSqyuPB3lUhuzqf1J5sVtvjcT8Ml/AmyiqWxfm/8CCe/Z3jU95gFz8HXU0xXVoL9IzXPKCLSOohBwvVyHQgXO5mIIzeVqXfB7iduse8cGuLBZKhVmWfM+1B/yBAUN75ejt1bce1Gn1mAVHqPKr51F5mjkEQad2LWSakGdY8xf1qTDilE6noFbeRfnquCR/qU+2HnYmsUiQnigGBLOMCvR/PpjAV92QUzUToz3em/0aiPDC6qi3OM4jOx0QDcSoOQVkZddGtLYpwrjknvQ/2HPvLt00QHQ9OJiy/4RzYYvunwOatNYTCFQbjPlQA5Ui63cF3JwfMKjYNOJeISwDqo7HJYBY X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(24454002)(189002)(199003)(46406003)(106466001)(77096005)(50466002)(46102003)(5008740100001)(110136002)(83506001)(189998001)(105606002)(93886004)(85426001)(87936001)(2950100001)(86362001)(5007970100001)(33716001)(92566002)(11100500001)(104016004)(23726002)(97736004)(81156007)(97756001)(4001350100001)(33656002)(6806005)(69596002)(76176999)(5001960100002)(54356999)(47776003)(64706001)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB1274;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1274;2:6HgxOS231Dfc2SXxTlEQrliPek4VZIvvIXFhIcWoXBqEEldRYkxgdbIGrv3BdNZH1uGoZGVTU1+Do9siM4rQncQv3SMNZUj5LJKiyNCkmWCzbaE3SKohKryKnOUy4hLINTT062YJ5II5U0X9+IcoKkA8Pk5dF9CBVO3rY96xnns=;3:lxrrHFZ1KEAEKVJbzR9o7OJlZ09iiuBM2ZniVKs7pBBiChP+FtR5rtcT6TI8BqWAIw89Q1c0EZMxYFTRqEk7kCBmBOgjCVXWczRtVW2PDdO/87rzGwa85nBkdo/EzjTKysbbNx9cqapsQ1UJNGTEaZvlq9iAk6F0f4Hpq0LbNYHSJnggiGiKF1RxJzqg+hAlXMMVEhjtD9oOyGMKPDqlrEWLmEDW3U96Tf5XXILNQB0=;25:26DyHOW6rOkdzYKCgh8j0iqEdSozT0mMmv/HKtkKMLpgZ/ZtYq7Cb63ufNKX+A4WNsRQv/28DD0UtCJJAFJkapH9OxjjCIqGWliBY4Yr95iGdpB0h10AI1DtNrH7NtiSN3mlxN5ZNqQWbij68w7XRxjRtvlQPIKoqTv+doluagIkxhjN2Y0Wxs3TomKNxnK8Hgrk/w0c4vehfWIQyc3+lWbTjiltkny9303uwFmBqkOsMOZYizHx83N3ONsp9SiYh18zSPHiGZZ4ssQEiztT3Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1274; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1274;20:iVNNBH8eMxOPhOK9T32r4rc6+tzKb9xRGaw7eUKp+0bKet01gmIY47STDjy+18Gj+rNgXyC3gbkP1+42C2WDd6HdMuW2b4a8QVGtjoTFz5riUaFj/sTE2wT+nwjZPQrJHjr38QQ4ZBnOCzst8te7ylFm5sVBTK45OD5YQy+6uLefGFapbeq1ZKhDgCcF625fg3axwSXBc/Q4MVYstHEs710BH4JNjxRz2+ZInTsVFcnujCLjds+ERLy49er0c6iQXBs0gJ8lyW1I+jDTbjk/71U9osecweL0TUyHNgVn9VKL1ZIqCAUzKxHNax0GiBVx9OmdoKLFK/8rFh0oR1bdwoW0GYmG5Ch6gHDRiti0aRE=;4:dYvfl+/3mcSCl3qJp8a4iUt5SgwbfLJjPdoxgbX+u3xPf9cdwVrOnSUCF4qJU6FhETDWUbELwisfumHAoqDjcaCxuBSTlk5RxJ/OTygx7XtLFFU4tlCrqY1dio9IhDjhx+JaPd5LBJBw9FAuunRMEe5Cu/7+sIaFTq9OCyPmJQWxpNdAujXvXq/oxcetYfAdwGbUhStVGoEQh+LxM3qJBKr/ASGzAdOEo1LTxUzZS+ED01RSJ0Z94TT8O3yxochwq1sgYJo9XhRpIJ5yKUoeASzJ5vxl2xytgAd9sv8ybP4yCKwIgjmASy2Ceq8mlVmYOb9ghKpTydjCmrMUWhDHagZWe8jztr6OWKOvfWP1dMI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:CY1PR0301MB1274;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1274; X-Forefront-PRVS: 0725D9E8D0 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB1274;23:Tt2WqrBF6bQOmS2t53DkzWAFLnpbD5inbv+0jha?= =?us-ascii?Q?IgUHpnf9EMT6akacqfXoa4JTWGqadfp8NJZ61Lrt1mQd2B/TgP+2Zlyp7IRc?= =?us-ascii?Q?wrTWw5rjjXHObTxMK5CR8PRbIfRJewm662jStebYPgrMu++yEfQh1kKI9wiK?= =?us-ascii?Q?nX8NERAB3E2fgBo3fKnqNGOYccw23eR1peRDiVz9rOK/kODzZ2XBCJ34zH2e?= =?us-ascii?Q?YkGyDVmch3XCs0f6rwrK55Z3HsJFxrzHVOQzL/BJV2Ah54Z4DG4/dMDWrt6Q?= =?us-ascii?Q?nBbvF1HoFuDANJbidN3sh4XNmxeIhPtn6UvTvpyDh8SB99QjBDLfmDVWJEyJ?= =?us-ascii?Q?mY1ZQD/n6t2FnssepVUIU1JkwgxNkrwFkpHdFgLOcH1rwRhQ9x4CuIxYVGSU?= =?us-ascii?Q?+i4dD7VoxmUY9+M0Mw+N3DUT9XHIVYwNkVS73Qp3wG6yZxbWU7+WNpZm9rOT?= =?us-ascii?Q?IeNoD5+gjBlyrz3psW83aahKv9yGiLjRqq9mp8yYud+HQ5mn7qtdeEBPl3f3?= =?us-ascii?Q?7q+sLv1y9VmvbwUFIlcxrN8uNSXMgv9g/sTsJrglgY4P2mS8GHqdCAr9wbiu?= =?us-ascii?Q?sc+nslSd1nFdlovmwdiu+FcBZcIkt/ZYlx8wpw9aQRGowJ6Xv7I258Sug+/K?= =?us-ascii?Q?9GqEolIWHISHhNj4NUXGYB0Q0+n9j/nWYyCkcf2il/OiKlT+KGIPqOSaFqkF?= =?us-ascii?Q?iuOvaMUrDgLG11G/f1XxymetnSyjmIOjl2q93Lq7rK3DTZHq89mdX5/R0RQo?= =?us-ascii?Q?fvMW3Uzwo3zhP0vk91hSUsNT3G5v46xWRDsESJLGGDt51RP4knPolDaEOckg?= =?us-ascii?Q?nw10B2pJsVVLuUgIsIEs7mBdok8eXVUgkn+Siq12hJVa5Da/hbzUP4j0JpI6?= =?us-ascii?Q?Aif5HV6URJvvTw7GAGGZjb+92kQvxG4xCcPzQ8hafGqoyVKomnoqCyx1BRe3?= =?us-ascii?Q?32dz8+E/8nHONAI16UugoTVrOmwokouXAnHvlLKI/vm3XqvX5I2aQzVvIaeZ?= =?us-ascii?Q?jxafyW9dO9PY0rCDd0gvnkMaLatQ1IlD55WJrIY+lUKaFduPJnt4DbV3ePL7?= =?us-ascii?Q?wqAgjaxn/9KcsIK9WetflXzAUWE7Sv4WD6jzE8blqdArxYKJN4FgD6XGp0OB?= =?us-ascii?Q?2tWYLzd37XGQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1274;5:2oxSc1brfKsY0LqIjSOtdLAe433B3XjcLKl3POGTQnmTRjC/0KetPx7TR/ARfDY52wDJAjjL/4osmg8AtN/kf9pVb1YSJ2wsY06cR9XxomH2CetFtv/CIZ6tkBOpqvstTHk3UTmMQjtZZCpz/DTVJQ==;24:psT4P/upWd+/ppoiZDVCztEMHdiySrhS5q4/7IjlpRV1bMRK/ijGbK6MCIoSMYHun4qbkcrdHfxaGJ9+wxp7rx47TnSWh905kJ0xSwxfXnU=;20:CEVkItwylyqne3XBk3Wku6s1CGVCiwg6xlu6SoUszAC+Zj3gx0LxkY0zLyUIqZTX0yMOdoVJXXZvSjBS/t/pyg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2015 01:46:38.5331 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1274 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 10, 2015 at 09:11:55AM +0800, Shawn Guo wrote: > On Fri, Oct 09, 2015 at 05:15:30PM +0800, Shengjiu Wang wrote: > > SPDIF_GCLK is also spdif's clock, it use a same enable bit with SPDIF_ROOT_CLK, > > We didn't separate them in clock tree before. > > Is it the clock described as "Global clock" in Reference Manual, SPDIF Yes. > chapter? If that's the case, you are just adding a missing SPDIF clock > rather than fixing a low power mode issue, and I will be fine. But > still you should reword the commit log to make it clear, that the patch > is to correct a SPDIF clock setting issue, which is just discovered by > low power mode support. > Ok, I will refine the patch comments, and send it later. > Shawn