From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752250AbbJJVq2 (ORCPT ); Sat, 10 Oct 2015 17:46:28 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:33006 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbbJJVq1 (ORCPT ); Sat, 10 Oct 2015 17:46:27 -0400 Date: Sat, 10 Oct 2015 14:46:26 -0700 From: Darren Hart To: Henrique de Moraes Holschuh Cc: Linux Kernel Mailing List , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] thinkpad_acpi: Add TP_HKEY_EV_SCREEN_FLIP (0x60c0) for Lenovo ThinkPad Yoga 12 Message-ID: <20151010214626.GA2958@malice.jf.intel.com> References: <20151010184509.GA27137@malice.jf.intel.com> <20151010214034.GA9431@khazad-dum.debian.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151010214034.GA9431@khazad-dum.debian.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 10, 2015 at 06:40:34PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 10 Oct 2015, Darren Hart wrote: > > On Sat, Oct 10, 2015 at 11:41:47AM -0700, Darren Hart wrote: > > > From: Darren Hart > > > > > > thinkpad_acpi reports "unhandled HKEY event 0x60c0" when switching > > > between laptop and tent/tablet mode on the ThinkPad Yoga 12. This key is > > > reported by atkbd serio0 as e058 and e059. > > > > > > Add TP_HKEY_EV_SCREEN_FLIP to the list of ignored events and silence the > > > warning. > > > > > > Cleanup whitespace on preceeding line for TP_HKEY_EV_KEY_FN_ESC. > > > > > > Signed-off-by: Darren Hart > > > Cc: Henrique de Moraes Holschuh > > > Cc: ibm-acpi-devel@lists.sourceforge.net > > Acked-by: Henrique de Moraes Holschuh Thanks Henrique, Now, as I'm digging into this I'm finding maybe there is more to this. Should I be attempting to tie this in to the tablet switch mechanism for the older x61t? Or is this something we now want to strictly hand off to a userspace helper via the atkbd event? -- Darren Hart Intel Open Source Technology Center