From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751805AbbJKRUK (ORCPT ); Sun, 11 Oct 2015 13:20:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54532 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751168AbbJKRUI (ORCPT ); Sun, 11 Oct 2015 13:20:08 -0400 Date: Sun, 11 Oct 2015 19:20:05 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: linux-arm-kernel , Hans de Goede , linux-kernel , linux-sunxi Subject: Re: [PATCH v3 5/5] ARM: sun5i: Add C.H.I.P DTS Message-ID: <20151011172005.GV2278@lukather> References: <1444380177-15302-1-git-send-email-maxime.ripard@free-electrons.com> <1444380177-15302-6-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="59coWm5189RNS6mf" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --59coWm5189RNS6mf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 09, 2015 at 11:22:23PM +0800, Chen-Yu Tsai wrote: > On Fri, Oct 9, 2015 at 4:42 PM, Maxime Ripard > wrote: > > The C.H.I.P. is a small SBC with an Allwinner R8, 8GB of NAND, 512MB of > > RAM, USB host and OTG, a wifi / bluetooth combo chip, an audio/video ja= ck > > and two connectors to plug additional boards on top of it. > > > > Signed-off-by: Maxime Ripard > > Reviewed-by: Hans de Goede > > --- > > arch/arm/boot/dts/Makefile | 3 +- > > arch/arm/boot/dts/sun5i-r8-chip.dts | 213 ++++++++++++++++++++++++++++= ++++++++ > > 2 files changed, 215 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm/boot/dts/sun5i-r8-chip.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 342ab3116feb..bf165ed4e7fa 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -600,7 +600,8 @@ dtb-$(CONFIG_MACH_SUN5I) +=3D \ > > sun5i-a13-olinuxino.dtb \ > > sun5i-a13-olinuxino-micro.dtb \ > > sun5i-a13-q8-tablet.dtb \ > > - sun5i-a13-utoo-p66.dtb > > + sun5i-a13-utoo-p66.dtb \ > > + sun5i-r8-chip.dtb > > dtb-$(CONFIG_MACH_SUN6I) +=3D \ > > sun6i-a31-app4-evb1.dtb \ > > sun6i-a31-colombus.dtb \ > > diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/su= n5i-r8-chip.dts > > new file mode 100644 > > index 000000000000..0d450a828372 > > --- /dev/null > > +++ b/arch/arm/boot/dts/sun5i-r8-chip.dts >=20 > snip >=20 > > +®_dcdc2 { > > + regulator-min-microvolt =3D <1000000>; > > + regulator-max-microvolt =3D <1400000>; > > + regulator-name =3D "cpuvdd"; >=20 > Other boards seem to follow the power pin names on the SoC and call > this "vdd-cpu". >=20 > > + regulator-always-on; > > +}; > > + > > +®_dcdc3 { > > + regulator-min-microvolt =3D <1000000>; > > + regulator-max-microvolt =3D <1300000>; > > + regulator-name =3D "corevdd"; >=20 > And this was named "vdd-int" or "vdd-int-dll" (for SoCs with separate > VDD_DLL pins). >=20 > > + regulator-always-on; > > +}; > > + > > +®_ldo1 { > > + regulator-name =3D "rtcvdd"; >=20 > And this one was "vdd-rtc". >=20 > I know you followed the names set in the design doc. Just wondering if th= ere > should be some convention on these. I think if we have a document that clearly reference them with some other name, we should just stick with the name used there, especially if it's only cosmetic, which is the case here. > > +}; > > + > > +®_ldo2 { > > + regulator-min-microvolt =3D <2700000>; > > + regulator-max-microvolt =3D <3300000>; > > + regulator-name =3D "avcc"; > > + regulator-always-on; > > +}; > > + > > +®_ldo5 { > > + regulator-min-microvolt =3D <1800000>; > > + regulator-max-microvolt =3D <1800000>; > > + regulator-name =3D "vcc-1v8"; > > +}; > > + > > +®_usb0_vbus { > > + pinctrl-0 =3D <&chip_vbus_pin>; > > + vin-supply =3D <®_vcc5v0>; > > + gpio =3D <&pio 1 10 GPIO_ACTIVE_HIGH>; /* PB10 */ >=20 > status =3D "okay"; ? Ah, yes, indeed. > The rest looks good. Is that an Ack from you if I add the status ? Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --59coWm5189RNS6mf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWGppFAAoJEBx+YmzsjxAgVooQAJfBPP6DohcCfCh3TBd9gd5/ tNDa7uI6a1QqRTrF7mKsH3borcfLQ/AS6aVls0SQdi+gJLPZlYsFtippeGyX4mVY HdHqZEqKNwi8+H8b5o+n+0tAk+fDrCIgLKOK9PGixkFjQo80/RQdKjgUia2rJKVZ UzXB1Z1lK6Ag+urA0U1maWrs3uyrN8pdMzE9wZa7ysv+UjRvC7yiTfEA8ooTnOz6 5/pTSWujGIkOd25GEWFehXNtA9D+9n3cPLkhEtyXe44jHgwm9x4N/qwC1L6N/0ls d7KJH+c385YWsp+zHYQcyEu44kC0VL1mIwBNUJTMdmPG4Ln38iDZTsdungkwlUN4 L8OcU3GQQ7vtxi2mzKxBUjiOhC5Mikd4kJ1SGQEek13CyHcgb+Hhj0Vib4L5h7ep y4TNuDZ5bAeT01/uxsfGAHGH24yV/CIqPT78XVs3ZEwpoeNSOYwIhLyBg4V8JWem 2tSkYftqleNKdSWfKn3dDV8gF4W8G8TKI4jArSahiS7+kFdqzANnhN3XA3Bt82sK nStKlbzSwde5dwCInB7Nhr++73HAQKoE9v7CgDOpayYPkVEvutbggjyiyy++moxI Z3MEzt+G+HEq3Ee5OcsiU6BP99IzPlqOMoT2zygdfgB/iBzpedwu5FGBzghEQRSJ DiA1XaX7jyZaMabwpqe0 =yZ+w -----END PGP SIGNATURE----- --59coWm5189RNS6mf--