linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
	Michal Marek <mmarek@suse.cz>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
	Namhyung Kim <namhyung@gmail.com>,
	Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
	Chris J Arges <chris.j.arges@canonical.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Vrabel <david.vrabel@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Chris Wright <chrisw@sous-sol.org>,
	Alok Kataria <akataria@vmware.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>,
	Matt Fleming <matt.fleming@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org
Subject: Re: [PATCH v13 00/23] Compile-time stack metadata validation
Date: Mon, 12 Oct 2015 09:41:11 +0200	[thread overview]
Message-ID: <20151012074110.GB16543@gmail.com> (raw)
In-Reply-To: <20150928134547.GA16266@treble.redhat.com>


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> Hi Ingo,
> 
> Do you have any more objections to these patches?  Would you be willing
> to apply them?

So I still don't like the tool namespace you picked: Git-alike generic naming plus 
subcommands work so much better that I'm not sure why we are even having that 
discussion: if you name your tool 'stacktool' and alias everything you have today 
to under 'stacktool run ...' and add 'stacktool help' as a second, obvious 
subcommand then you'll have your current syntax and a lot more future flexibility 
and ability to branch off various functionality a'la Git, perf or kvmtool ...

It's an 100% equivalent superset of your current stacktool's parameter structure, 
so none of your prior objections apply.

Thanks,

	Ingo

  reply	other threads:[~2015-10-12  7:41 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 15:46 [PATCH v13 00/23] Compile-time stack metadata validation Josh Poimboeuf
2015-09-22 15:46 ` [PATCH v13 01/23] tools: Fix formatting of the "make -C tools" help message Josh Poimboeuf
2015-09-22 15:46 ` [PATCH v13 02/23] x86/asm: Frame pointer macro cleanup Josh Poimboeuf
2015-09-22 15:46 ` [PATCH v13 03/23] x86/asm: Add C versions of frame pointer macros Josh Poimboeuf
2015-09-22 15:46 ` [PATCH v13 04/23] x86/stacktool: Compile-time stack metadata validation Josh Poimboeuf
2015-09-23 11:38   ` Jiri Slaby
2015-09-23 11:40     ` Jiri Slaby
2015-09-23 12:42       ` [PATCH v13.1 " Josh Poimboeuf
2015-10-01 14:50         ` Chris J Arges
2015-10-01 15:25           ` Josh Poimboeuf
2015-10-01 15:38             ` Chris J Arges
2015-09-22 15:46 ` [PATCH v13 05/23] x86/stacktool: Add file and directory ignores Josh Poimboeuf
2015-09-22 15:46 ` [PATCH v13 06/23] x86/stacktool: Add ignore macros Josh Poimboeuf
2015-09-22 15:46 ` [PATCH v13 07/23] x86/xen: Add stack frame dependency to hypercall inline asm calls Josh Poimboeuf
2015-09-22 15:46 ` [PATCH v13 08/23] x86/paravirt: Add stack frame dependency to PVOP " Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 09/23] x86/paravirt: Create a stack frame in PV_CALLEE_SAVE_REGS_THUNK Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 10/23] x86/amd: Set ELF function type for vide() Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 11/23] x86/reboot: Add ljmp instructions to stacktool whitelist Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 12/23] x86/xen: Add xen_cpuid() and xen_setup_gdt() to stacktool whitelists Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 13/23] x86/asm/crypto: Create stack frames in aesni-intel_asm.S Josh Poimboeuf
2015-10-01  6:10   ` minipli
2015-10-01 13:29     ` Josh Poimboeuf
2015-10-01 17:36       ` Mathias Krause
2015-10-01 17:51         ` Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 14/23] x86/asm/crypto: Move .Lbswap_mask data to .rodata section Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 15/23] x86/asm/crypto: Move jump_table " Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 16/23] x86/asm/crypto: Create stack frames in clmul_ghash_mul/update() Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 17/23] x86/asm/entry: Create stack frames in thunk functions Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 18/23] x86/asm/acpi: Create a stack frame in do_suspend_lowlevel() Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 19/23] x86/asm: Create stack frames in rwsem functions Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 20/23] x86/asm/efi: Create a stack frame in efi_call() Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 21/23] x86/asm/power: Create stack frames in hibernate_asm_64.S Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 22/23] x86/uaccess: Add stack frame output operand in get_user inline asm Josh Poimboeuf
2015-09-22 15:47 ` [PATCH v13 23/23] x86/stacktool: Ignore head_$(BITS) files Josh Poimboeuf
2015-09-28 13:45 ` [PATCH v13 00/23] Compile-time stack metadata validation Josh Poimboeuf
2015-10-12  7:41   ` Ingo Molnar [this message]
2015-10-12 14:23     ` Josh Poimboeuf
2015-11-11 18:14       ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151012074110.GB16543@gmail.com \
    --to=mingo@kernel.org \
    --cc=akataria@vmware.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=bernd@petrovitsch.priv.at \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=chris.j.arges@canonical.com \
    --cc=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=david.vrabel@citrix.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=jpoimboe@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.cz \
    --cc=namhyung@gmail.com \
    --cc=palves@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).