From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751899AbbJLNxA (ORCPT ); Mon, 12 Oct 2015 09:53:00 -0400 Received: from outbound-smtp05.blacknight.com ([81.17.249.38]:47822 "EHLO outbound-smtp05.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbbJLNw7 (ORCPT ); Mon, 12 Oct 2015 09:52:59 -0400 Date: Mon, 12 Oct 2015 14:52:50 +0100 From: Mel Gorman To: yalin wang Cc: akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com, rientjes@google.com, js1304@gmail.com, kirill.shutemov@linux.intel.com, hannes@cmpxchg.org, alexander.h.duyck@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] mm: fix a BUG, the page is allocated 2 times Message-ID: <20151012135250.GA3625@techsingularity.net> References: <1444617606-8685-1-git-send-email-yalin.wang2010@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1444617606-8685-1-git-send-email-yalin.wang2010@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2015 at 10:40:06AM +0800, yalin wang wrote: > Remove unlikely(order), because we are sure order is not zero if > code reach here, also add if (page == NULL), only allocate page again if > __rmqueue_smallest() failed or alloc_flags & ALLOC_HARDER == 0 > > Signed-off-by: yalin wang Thanks very much for catching this! Acked-by: Mel Gorman With your current subject and changelog, there is a small risk that Andrew will miss this or not see it for some time. Would you mind resending the patch with a changelog similar to this please? It spells out that it is a fix to an mmotm patch so it'll be obvious where it should be inserted before merging to mainline. From: yalin wang Subject: [PATCH] mm, page_alloc: reserve pageblocks for high-order atomic allocations on demand -fix There is a redundant check and a memory leak introduced by a patch in mmotm. This patch removes an unlikely(order) check as we are sure order is not zero at the time. It also checks if a page is already allocated to avoid a memory leak. This is a fix to the mmotm patch mm-page_alloc-reserve-pageblocks-for-high-order-atomic-allocations-on-demand.patch Signed-off-by: yalin wang Acked-by: Mel Gorman