From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947AbbJLOUd (ORCPT ); Mon, 12 Oct 2015 10:20:33 -0400 Received: from verein.lst.de ([213.95.11.211]:53120 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbbJLOUb (ORCPT ); Mon, 12 Oct 2015 10:20:31 -0400 Date: Mon, 12 Oct 2015 16:20:28 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: Nicholas Bellinger , Christoph Hellwig , target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] samples: build configfs sample on when enabled Message-ID: <20151012142028.GA24695@lst.de> References: <6271650.CdczvJuMsL@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6271650.CdczvJuMsL@wuerfel> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2015 at 04:14:16PM +0200, Arnd Bergmann wrote: > Most samples have their own Kconfig option, but for some reason > the configfs sample does not have one and gets built unconditionally > when CONFIG_SAMPLES is enabled, which fails if CONFIG_CONFIGFS_FS > is not: > > ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined! > ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined! > > This adds a new Kconfig symbol to mirror the existing method and > only let the user enable this sample if configfs is present. > > Signed-off-by: Arnd Bergmann This should already be in version two of the series I sent last week.