From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbbJLN1K (ORCPT ); Mon, 12 Oct 2015 09:27:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:38706 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751801AbbJLN1I (ORCPT ); Mon, 12 Oct 2015 09:27:08 -0400 Date: Mon, 12 Oct 2015 15:27:03 +0200 From: Thomas Petazzoni To: Arnd Bergmann Cc: Tejun Heo , linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sata/mvebu: use #ifdef around suspend/resume code Message-ID: <20151012152703.4d82bd02@free-electrons.com> In-Reply-To: <5727002.l6plqmRKB3@wuerfel> References: <5727002.l6plqmRKB3@wuerfel> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd, On Mon, 12 Oct 2015 15:05:27 +0200, Arnd Bergmann wrote: > +#ifdef CONFIG_PM_SUSPEND Shouldn't this be CONFIG_PM_SLEEP ? The generic suspend/resume function in libahci_platform.c are defined when CONFIG_PM_SLEEP is enabled. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com