Re: [PATCH v9 2/9] Input: goodix - reset device at init

mika.westerberg
2015-10-14T11:20:38Z

On Tue, Oct 13, 2015 at 11:23:03PM -0700, Dmitry Torokhov wrote:
> I understand why one might use acpi_dev_add_driver_gpios() to augment
> data in ACPI, however here we have completely different issue: driver
> that expects named gpios gets returned gpio that has nothing to do with
> what it requested, because gpiolib acpi code always falls back to
> unnamed gpio if it does not find named gpio. That can be acceptable if
> driver uses the same con_id for all requests to gpiolib, but is not
> working when driver supplies different con_ids.

Right, the ACPI fallback ignores con_id completely and uses only the
index.

AFAIK there is only one driver using ACPI _CRS index method:
sdhci-[acpi|pci].c. If we can convert that to use acpi_dev_add_driver_gpios()
to feed names for card detection GPIOs, I think we can remove the
fallback alltogether in favor of named GPIOs for ACPI.