From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751725AbbJLRZx (ORCPT ); Mon, 12 Oct 2015 13:25:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56901 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbbJLRZw (ORCPT ); Mon, 12 Oct 2015 13:25:52 -0400 Date: Mon, 12 Oct 2015 10:25:51 -0700 From: Greg Kroah-Hartman To: Hartley Sweeten Cc: Ian Abbott , "driverdev-devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/2] staging: comedi: comedidev.h: fix some checkpatch issues Message-ID: <20151012172551.GA8815@kroah.com> References: <1444669405-27121-1-git-send-email-abbotti@mev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2015 at 05:22:29PM +0000, Hartley Sweeten wrote: > On Monday, October 12, 2015 10:03 AM, Ian Abbott wrote: > > Fix some checkpatch issues in "comedidev.h". There are still some > > CamelCase warnings, but since those are for the use of "mA" and it > > represents "milliamps", I think I'll leave them alone. > > > > 1) staging: comedi: comedidev.h: add comments to spin-lock and mutex > > 2) staging: comedi: comedidev.h: spaces preferred around that '*' > > > > drivers/staging/comedi/comedidev.h | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > Thanks! > > Reviewed-by: H Hartley Sweeten > > Ian, > > Just a comment... > > The checkpaatch.pl noise about "mA" defines are a bit annoying but > I agree that those defines are clearer than "{foo}_milliamps". I agree, checkpatch is just a "hint", feel free to ignore it when it says stupid things. Like this. thanks, greg k-h