From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752246AbbJLRwT (ORCPT ); Mon, 12 Oct 2015 13:52:19 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:37951 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbbJLRwQ (ORCPT ); Mon, 12 Oct 2015 13:52:16 -0400 X-IronPort-AV: E=Sophos;i="5.17,674,1437462000"; d="scan'208";a="77225950" Date: Mon, 12 Oct 2015 13:52:02 -0400 From: Jon Mason To: Stephen Boyd CC: Michael Turquette , Florian Fainelli , Hauke Mehrtens , Ray Jui , Scott Branden , , , , , Subject: Re: [PATCH 09/10] clk: ns2: add clock support for Broadcom Northstar 2 SoC Message-ID: <20151012175202.GE20867@broadcom.com> References: <1443826665-17570-1-git-send-email-jonmason@broadcom.com> <1443826665-17570-10-git-send-email-jonmason@broadcom.com> <20151010001915.GY26883@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151010001915.GY26883@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2015 at 05:19:15PM -0700, Stephen Boyd wrote: > On 10/02, Jon Mason wrote: > > diff --git a/drivers/clk/bcm/clk-ns2.c b/drivers/clk/bcm/clk-ns2.c > > new file mode 100644 > > index 0000000..1d08281 > > --- /dev/null > > +++ b/drivers/clk/bcm/clk-ns2.c > > @@ -0,0 +1,290 @@ > > +/* > > + * Copyright (C) 2015 Broadcom Corporation > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation version 2. > > + * > > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any > > + * kind, whether express or implied; without even the implied warranty > > + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > clkdev looks unused here too? > > > +#include > > +#include > > And this one? Yes, already caught this when you mentioned the other file :) > > > + > > +#include > > +#include "clk-iproc.h" > > + > > +#define reg_val(o, s, w) { .offset = o, .shift = s, .width = w, } > > I guess we missed this one already, but this isn't a macro > resembling a function. Kernel style is to capitalize this sort of > macro. I agree, but I was following prior example in drivers/clk/bcm/clk-cygnus.c. I can make the changes here and do a patch for that file making the necessary changes as well. Just let me know your preference. Thanks, Jon > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project