From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbbJLUMr (ORCPT ); Mon, 12 Oct 2015 16:12:47 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:37086 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbbJLUMp (ORCPT ); Mon, 12 Oct 2015 16:12:45 -0400 X-Greylist: delayed 472 seconds by postgrey-1.27 at vger.kernel.org; Mon, 12 Oct 2015 16:12:45 EDT Date: Mon, 12 Oct 2015 22:04:23 +0200 From: Sam Ravnborg To: yalin wang Cc: linux@arm.linux.org.uk, arnd@arndb.de, ard.biesheuvel@linaro.org, will.deacon@arm.com, nico@linaro.org, keescook@chromium.org, catalin.marinas@arm.com, victor.kamensky@linaro.org, msalter@redhat.com, vladimir.murzin@arm.com, ggdavisiv@gmail.com, paul.gortmaker@windriver.com, mingo@kernel.org, rusty@rustcorp.com.au, mcgrof@suse.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com, aarcange@redhat.com, mhocko@suse.com, jack@suse.cz, iamjoonsoo.kim@lge.com, xiexiuqi@huawei.com, vbabka@suse.cz, Vineet.Gupta1@synopsys.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC] arm: add __initbss section attribute Message-ID: <20151012200422.GA29175@ravnborg.org> References: <1444622356-8263-1-git-send-email-yalin.wang2010@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444622356-8263-1-git-send-email-yalin.wang2010@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > > -#define BSS_SECTION(sbss_align, bss_align, stop_align) \ > +#define BSS_SECTION(sbss_align, bss_align, initbss_align, stop_align) \ A few comments: 1) - please align the backslash at the end of the line with the backslash above it. 2) - you need to fix all the remaining users of BSS_SECTION. 3) - do we really need the flexibility to specify an alignment (stop_align)? If not - drop the extra argument. Sam