From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484AbbJLWNE (ORCPT ); Mon, 12 Oct 2015 18:13:04 -0400 Received: from muru.com ([72.249.23.125]:57917 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbbJLWNB (ORCPT ); Mon, 12 Oct 2015 18:13:01 -0400 Date: Mon, 12 Oct 2015 15:12:56 -0700 From: Tony Lindgren To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, nsekhar@ti.com, linux@arm.linux.org.uk Subject: Re: [PATCH v2 1/4] ARM: dts: dra7: Add dt node for the sycon pcie Message-ID: <20151012221255.GG23801@atomide.com> References: <1442323985-29939-1-git-send-email-kishon@ti.com> <1442323985-29939-2-git-send-email-kishon@ti.com> <20151012212149.GZ23801@atomide.com> <561C2A1B.3000201@ti.com> <20151012220322.GF23801@atomide.com> <561C2E93.3020809@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561C2E93.3020809@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Kishon Vijay Abraham I [151012 15:09]: > Hi, > > On Tuesday 13 October 2015 03:33 AM, Tony Lindgren wrote: > > * Kishon Vijay Abraham I [151012 14:50]: > >> Hi Tony, > >> > >> On Tuesday 13 October 2015 02:51 AM, Tony Lindgren wrote: > >>> * Kishon Vijay Abraham I [150915 06:37]: > >>>> Add new device tree node for the control module register space where > >>>> PCIe registers are present. > >>>> > >>>> Signed-off-by: Kishon Vijay Abraham I > >>>> --- > >>>> arch/arm/boot/dts/dra7.dtsi | 5 +++++ > >>>> 1 file changed, 5 insertions(+) > >>>> > >>>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > >>>> index 5d65db9..0769b5d 100644 > >>>> --- a/arch/arm/boot/dts/dra7.dtsi > >>>> +++ b/arch/arm/boot/dts/dra7.dtsi > >>>> @@ -154,6 +154,11 @@ > >>>> compatible = "syscon"; > >>>> reg = <0x1c04 0x0020>; > >>>> }; > >>>> + > >>>> + scm_conf_pcie: tisyscon@1c24 { > >>>> + compatible = "syscon"; > >>>> + reg = <0x1c24 0x0024>; > >>>> + }; > >>>> }; > >>>> > >>>> cm_core_aon: cm_core_aon@5000 { > >>> > >>> > >>> Why don't you just extend the existing scm_conf1 area? This is not all pcie > >>> specific for scm_conf_pcie, at least for PLLEN_CONTROL, RMII_CLK_SETTING > >>> and MUXSEL_32K_CLKIN. > >> > >> scm_conf_pcie has only PCIe registers (it starts at 0x4A003C24). > >> PLLEN_CONTROL and others are at 0x4A003C14 as per > >> DRA75x_DRA74x_SR1.1_NDA_TRM_vW. > > > > Oh sorry I guess I was looking at a wrong address then. > > > >> Since PCIe itself has a bunch of registers for itself, thought of > >> creating a separate dt node. But I can extend scm_conf1 area. > > > > Why not just ioremap them then? Do these need to be shared with > > some other driver? > > yeah, some are used by PCIe controller driver and some are used by PCIe > PHY driver. OK makes sense to me then. Thanks, Tony