From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbbJLWxe (ORCPT ); Mon, 12 Oct 2015 18:53:34 -0400 Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:54739 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbbJLWxc (ORCPT ); Mon, 12 Oct 2015 18:53:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DpFQBfORxWPCSkLHldgyZUbqkgAQEBAQEBBosbhRqGCh2CdoIKeQICAQECgTRNAQEBAQEBBwEBAQFBP0EGg2ABAQQ6HCMQCAMYCSUPBSUDBxoTiC0OwAkBAQEBAQEBAwEBAQEBGQQZhhOFRYJugh8HgxqBFAWWE4UZh3mcC4R5KjMBhDyCNAEBAQ Date: Tue, 13 Oct 2015 09:53:27 +1100 From: Dave Chinner To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, Alexander Viro , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Dan Williams , Jan Kara , "Kirill A. Shutemov" , linux-nvdimm@ml01.01.org, Matthew Wilcox Subject: Re: [PATCH v5] mm, dax: fix DAX deadlocks Message-ID: <20151012225327.GF27164@dastard> References: <1444258729-21974-1-git-send-email-ross.zwisler@linux.intel.com> <1444258729-21974-2-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444258729-21974-2-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 04:58:49PM -0600, Ross Zwisler wrote: > The following two locking commits in the DAX code: > > commit 843172978bb9 ("dax: fix race between simultaneous faults") > commit 46c043ede471 ("mm: take i_mmap_lock in unmap_mapping_range() for DAX") > > introduced a number of deadlocks and other issues which need to be fixed > for the v4.3 kernel. The list of issues in DAX after these commits (some > newly introduced by the commits, some preexisting) can be found here: > > https://lkml.org/lkml/2015/9/25/602 > > This undoes most of the changes introduced by those two commits, > essentially returning us to the DAX locking scheme that was used in v4.2. > > Signed-off-by: Ross Zwisler I've run this through some testing, the deadlocks aren't present and there don't appear to be any new regressions, so IMO this is fine to go to Linus. Tested-by: Dave Chinner Cheers, Dave. -- Dave Chinner david@fromorbit.com