From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932418AbbJMCa5 (ORCPT ); Mon, 12 Oct 2015 22:30:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:46591 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932346AbbJMCaz (ORCPT ); Mon, 12 Oct 2015 22:30:55 -0400 Date: Mon, 12 Oct 2015 23:30:50 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH] perf hists browser: Add 'm' key for context menu display Message-ID: <20151013023050.GQ14409@kernel.org> References: <1444694521-8136-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444694521-8136-1-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 13, 2015 at 09:02:01AM +0900, Namhyung Kim escreveu: > With horizontal scrolling, the left/right arrow keys are used to > scroll columns and ENTER/ESC keys are used to enter/exit menu. > However if callchain is recorded, the ENTER key is used to toggle > callchain expansion so there's no way to display menu. Use 'm' key to > display the menu for this case. Thanks, applied. - Arnaldo > Signed-off-by: Namhyung Kim > --- > tools/perf/ui/browsers/hists.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c > index 9b7346a881cf..c8ec9bdb9c04 100644 > --- a/tools/perf/ui/browsers/hists.c > +++ b/tools/perf/ui/browsers/hists.c > @@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, > "E Expand all callchains\n" \ > "F Toggle percentage of filtered entries\n" \ > "H Display column headers\n" \ > + "m Display context menu\n" \ > "S Zoom into current Processor Socket\n" \ > > /* help messages are sorted by lexical order of the hotkey */ > @@ -1934,6 +1935,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, > continue; > case K_ENTER: > case K_RIGHT: > + case 'm': > /* menu */ > break; > case K_ESC: > -- > 2.6.1