[PATCH] perf hists browser: Add 'm' key for context menu display

[PATCH] perf hists browser: Add 'm' key for context menu display

[Namhyung Kim]

With horizontal scrolling, the left/right arrow keys are used to
scroll columns and ENTER/ESC keys are used to enter/exit menu.
However if callchain is recorded, the ENTER key is used to toggle
callchain expansion so there's no way to display menu.  Use 'm' key to
display the menu for this case.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/ui/browsers/hists.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 9b7346a881cf..c8ec9bdb9c04 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
 	"E             Expand all callchains\n"				\
 	"F             Toggle percentage of filtered entries\n"		\
 	"H             Display column headers\n"			\
+	"m             Display context menu\n"				\
 	"S             Zoom into current Processor Socket\n"		\
 
 	/* help messages are sorted by lexical order of the hotkey */
@@ -1934,6 +1935,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
 			continue;
 		case K_ENTER:
 		case K_RIGHT:
+		case 'm':
 			/* menu */
 			break;
 		case K_ESC:
-- 
2.6.1

Re: [PATCH] perf hists browser: Add 'm' key for context menu display

[Arnaldo Carvalho de Melo]

Em Tue, Oct 13, 2015 at 09:02:01AM +0900, Namhyung Kim escreveu:
> With horizontal scrolling, the left/right arrow keys are used to
> scroll columns and ENTER/ESC keys are used to enter/exit menu.
> However if callchain is recorded, the ENTER key is used to toggle
> callchain expansion so there's no way to display menu.  Use 'm' key to
> display the menu for this case.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/ui/browsers/hists.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index 9b7346a881cf..c8ec9bdb9c04 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
>  	"E             Expand all callchains\n"				\
>  	"F             Toggle percentage of filtered entries\n"		\
>  	"H             Display column headers\n"			\
> +	"m             Display context menu\n"				\
>  	"S             Zoom into current Processor Socket\n"		\
>  
>  	/* help messages are sorted by lexical order of the hotkey */
> @@ -1934,6 +1935,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
>  			continue;
>  		case K_ENTER:
>  		case K_RIGHT:
> +		case 'm':
>  			/* menu */
>  			break;
>  		case K_ESC:
> -- 
> 2.6.1

[tip:perf/core] perf hists browser: Add 'm' key for context menu display

[tip-bot for Namhyung Kim]

Commit-ID:  31eb4360546b4bd890f349db01295a173c09b0fb
Gitweb:     http://git.kernel.org/tip/31eb4360546b4bd890f349db01295a173c09b0fb
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 13 Oct 2015 09:02:01 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 12 Oct 2015 23:29:14 -0300

perf hists browser: Add 'm' key for context menu display

With horizontal scrolling, the left/right arrow keys are used to scroll
columns and ENTER/ESC keys are used to enter/exit menu.  However if
callchain is recorded, the ENTER key is used to toggle callchain
expansion so there's no way to display menu.  Use 'm' key to display the
menu for this case.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1444694521-8136-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/ui/browsers/hists.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 7728349..e5afb89 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
 	"E             Expand all callchains\n"				\
 	"F             Toggle percentage of filtered entries\n"		\
 	"H             Display column headers\n"			\
+	"m             Display context menu\n"				\
 	"S             Zoom into current Processor Socket\n"		\
 
 	/* help messages are sorted by lexical order of the hotkey */
@@ -1935,6 +1936,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
 			continue;
 		case K_ENTER:
 		case K_RIGHT:
+		case 'm':
 			/* menu */
 			break;
 		case K_ESC: