From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752048AbbJMFlT (ORCPT <rfc822;w@1wt.eu>);
	Tue, 13 Oct 2015 01:41:19 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:40039 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751257AbbJMFlR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 13 Oct 2015 01:41:17 -0400
Date: Mon, 12 Oct 2015 20:43:14 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: punit vara <punitvara@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>, devel@driverdev.osuosl.org,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Joshua Clayton <stillcompiling@gmail.com>,
        linux-kernel@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over
 memcmp()
Message-ID: <20151013034314.GA24094@kroah.com>
References: <1444675591-23947-1-git-send-email-punitvara@gmail.com>
 <CABXAfNJUkg4sUJ_j=_M01HGKBrt-fpzz6=OzSrmNvRzBSDPpxg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABXAfNJUkg4sUJ_j=_M01HGKBrt-fpzz6=OzSrmNvRzBSDPpxg@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 13, 2015 at 12:19:12AM +0530, punit vara wrote:
> On Tue, Oct 13, 2015 at 12:16 AM, Punit Vara <punitvara@gmail.com> wrote:
> > This patch is to the rtl871x_ioctl_linux.c file that fixes up following
> > warning reported by checkpatch.pl :
> >
> > -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
> >
> > bssid and pnetwork->network.MacAddress both are 6 byte
> > array which aligned with u16
> >
> > Signed-off-by: Punit Vara <punitvara@gmail.com>
> > ---
> >  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > index 143be0f..b19556a 100644
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > @@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
> >                         return -EINVAL;
> >                 }
> >                 netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
> > -               if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
> > +               if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
> >                         /* BSSID match, then check if supporting wpa/wpa2 */
> >                         pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
> >                                &wpa_ielen, pnetwork->network.IELength-12);
> > --
> > 2.5.3
> >
> 
> I have updated the patch as per feedback from various developers. As I
> am sending second time subject should be patch v2 right ?

Please resend the whole series please.