From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932343AbbJMDoK (ORCPT ); Mon, 12 Oct 2015 23:44:10 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:36057 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932278AbbJMDoH (ORCPT ); Mon, 12 Oct 2015 23:44:07 -0400 Date: Tue, 13 Oct 2015 09:13:58 +0530 From: Viresh Kumar To: Stephen Boyd Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] debugfs: Consolidate file mode checks in debugfs_create_*() Message-ID: <20151013034358.GO5386@linux> References: <1444698552-12369-1-git-send-email-sboyd@codeaurora.org> <1444698552-12369-2-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444698552-12369-2-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-10-15, 18:09, Stephen Boyd wrote: > The code that creates debugfs file with different file ops based > on the file mode is duplicated in each debugfs_create_*() API. > Consolidate that code into debugfs_create_mode(), that takes > three file ops structures so that we don't have to keep > copy/pasting that logic. > > Signed-off-by: Stephen Boyd > --- > fs/debugfs/file.c | 98 ++++++++++++++++++------------------------------------- > 1 file changed, 32 insertions(+), 66 deletions(-) Reviewed-by: Viresh Kumar -- viresh