From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932417AbbJMDod (ORCPT ); Mon, 12 Oct 2015 23:44:33 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34904 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932278AbbJMDob (ORCPT ); Mon, 12 Oct 2015 23:44:31 -0400 Date: Tue, 13 Oct 2015 09:14:21 +0530 From: Viresh Kumar To: Stephen Boyd Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] debugfs: Add read-only/write-only x64 file ops Message-ID: <20151013034421.GP5386@linux> References: <1444698552-12369-1-git-send-email-sboyd@codeaurora.org> <1444698552-12369-3-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444698552-12369-3-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-10-15, 18:09, Stephen Boyd wrote: > There aren't any read-only or write-only x64 file ops, but there > is a caller of debugfs_create_x64() that calls it with mode equal > to S_IRUGO. This leads to the possibility of userspace modifying > the file, so let's use the newly created debugfs_create_mode() > helper here to fix this. > > Signed-off-by: Stephen Boyd > --- > fs/debugfs/file.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Viresh Kumar -- viresh