From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751796AbbJMFxN (ORCPT ); Tue, 13 Oct 2015 01:53:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40577 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbbJMFxL (ORCPT ); Tue, 13 Oct 2015 01:53:11 -0400 Date: Mon, 12 Oct 2015 22:40:22 -0700 From: Greg KH To: Liao Tonglang Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers :staging: android: make alignment match open parenthesis Message-ID: <20151013054022.GA20952@kroah.com> References: <1444707151-16990-1-git-send-email-liaotonglang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444707151-16990-1-git-send-email-liaotonglang@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 11:32:31AM +0800, Liao Tonglang wrote: > Cleanup for checkpatch.pl warn below: > CHECK: Alignment should match open parenthesis > #836: FILE: drivers/staging/android/ashmem.c:836: > by split three lines to four. > > Signed-off-by: Liao Tonglang > --- > drivers/staging/android/ashmem.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index 60200a3..99fc7dc 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -832,9 +832,10 @@ static int __init ashmem_init(void) > { > int ret; > > - ashmem_area_cachep = kmem_cache_create("ashmem_area_cache", > - sizeof(struct ashmem_area), > - 0, 0, NULL); > + ashmem_area_cachep = > + kmem_cache_create("ashmem_area_cache", > + sizeof(struct ashmem_area), > + 0, 0, NULL); Now you are just getting very picky for checkpatch issues, is this really more readable? thanks, greg k-h