Re: [PATCH] drivers :staging: android: make alignment match open parenthesis

Greg KH
2015-10-13T05:53:13Z

On Tue, Oct 13, 2015 at 11:32:31AM +0800, Liao Tonglang wrote:
> Cleanup for checkpatch.pl warn below:
> CHECK: Alignment should match open parenthesis
> #836: FILE: drivers/staging/android/ashmem.c:836:
> by split three lines to four.
>
> Signed-off-by: Liao Tonglang <liaotonglang@gmail.com>
> ---
> drivers/staging/android/ashmem.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 60200a3..99fc7dc 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -832,9 +832,10 @@ static int __init ashmem_init(void)
> {
> int ret;
>
> - ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
> - sizeof(struct ashmem_area),
> - 0, 0, NULL);
> + ashmem_area_cachep =
> + kmem_cache_create("ashmem_area_cache",
> + sizeof(struct ashmem_area),
> + 0, 0, NULL);

Now you are just getting very picky for checkpatch issues, is this
really more readable?

thanks,

greg k-h