From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbbJMHGR (ORCPT ); Tue, 13 Oct 2015 03:06:17 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35156 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbbJMHGO (ORCPT ); Tue, 13 Oct 2015 03:06:14 -0400 Date: Tue, 13 Oct 2015 08:06:10 +0100 From: Lee Jones To: Ingi Kim Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sameo@linux.intel.com, rpurdie@rpsys.net, j.anaszewski@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, beomho.seo@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device Message-ID: <20151013070610.GO17172@x1> References: <1444655578-19806-1-git-send-email-ingi2.kim@samsung.com> <1444655578-19806-3-git-send-email-ingi2.kim@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1444655578-19806-3-git-send-email-ingi2.kim@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Oct 2015, Ingi Kim wrote: > This patch adds rt5033-led sub device to support it. > > Signed-off-by: Ingi Kim > --- > drivers/mfd/rt5033.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c > index d60f916..b7f374b 100644 > --- a/drivers/mfd/rt5033.c > +++ b/drivers/mfd/rt5033.c > @@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = { > }; > > static const struct mfd_cell rt5033_devs[] = { > - { .name = "rt5033-regulator", }, > { > + .name = "rt5033-regulator", > + }, { There's no need for this change. Please remove it. > .name = "rt5033-charger", > .of_compatible = "richtek,rt5033-charger", > }, { > .name = "rt5033-battery", > .of_compatible = "richtek,rt5033-battery", > + }, { > + .name = "rt5033-led", > + .of_compatible = "richtek,rt5033-led", For when you resubmit with the hunk above removed: Acked-by: Lee Jones > }, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog