From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752368AbbJMH4M (ORCPT ); Tue, 13 Oct 2015 03:56:12 -0400 Received: from m12-12.163.com ([220.181.12.12]:59966 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbbJMH4K (ORCPT ); Tue, 13 Oct 2015 03:56:10 -0400 Date: Tue, 13 Oct 2015 00:53:10 -0700 From: Geliang Tang To: David Miller , Don Fry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geliang Tang Subject: Re: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask Message-ID: <20151013075310.GA3705@ubuntu> References: <20151012.053814.1870650163021801761.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151012.053814.1870650163021801761.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-CM-TRANSID: DMCowED59lBmuBxWeZ8CCg--.978S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrJr15XF1UAF47JF1UJryrJFb_yoWxGFg_WF 1Iqr1rArZ7AFs7Aw1xKFyrur1qk345Xan5J3yDXFn093WfJw45XFyqy3Z7tFy8Jrn29F45 Gwn5CFy5ArWjyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUMa0JUUUUU== X-Originating-IP: [218.17.162.133] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiJQqSmVUL7eslGgAAsD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2015 at 05:38:14AM -0700, David Miller wrote: > From: Geliang Tang > Date: Fri, 9 Oct 2015 03:45:39 -0700 > > > pcnet32 can't work on my machine recently. It says "architecture > > does not support 32bit PCI busmaster DMA". There is a logic error > > in it: pci_set_dma_mask() return 0 means return successfully. > > > > Signed-off-by: Geliang Tang > > This driver doesn't call pci_set_dma_mask() in any of my tree(s). This patch is against linux-next tree. It was introduced by commit 9c034d4 'pcnet32: use pci_set_dma_mask insted of pci_dma_supported'.