Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection

Chanwoo Choi
2015-10-13T10:12:13Z

On 2015년 10월 13일 17:03, Lee Jones wrote:
> On Mon, 12 Oct 2015, Chanwoo Choi wrote:
>
>> On 2015년 10월 12일 19:16, Chanwoo Choi wrote:
>>> Hi Charles,
>>>
>>> On 2015년 10월 12일 17:45, Charles Keepax wrote:
>>>> On Wed, Oct 07, 2015 at 01:26:42PM +0100, Lee Jones wrote:
>>>>> On Wed, 07 Oct 2015, Mark Brown wrote:
>>>>>
>>>>>> On Fri, Oct 02, 2015 at 05:29:22PM +0100, Charles Keepax wrote:
>>>>>>> Add additional bindings to allow configuration of the system specific
>>>>>>> microphone detection settings.
>>>>>>
>>>>>> This all seems pretty much fine to me - the things it is controlling are
>>>>>> fairly specific to the way the former Wolfson devices do, they only
>>>>>> really make sense with a fairly particular algorithm which isn't widely
>>>>>> implemented.
>>>>>
>>>>> Is that an Ack?
>>>>
>>>> I am guessing Mark is slightly hesitant to ack as he probably
>>>> doesn't want to add reviewing all our jack detection bindings to
>>>> his already fairly sizable work load and doing so here likely
>>>> means it will be expected in the future. From talking to people at
>>>> LinuxCon it looks like it is pretty unlikely the DT maintainers
>>>> will be acking individual bindings as well, basically they are
>>>> only really looking at major/framework things and leaving the
>>>> rest to subsystem maintainers.
>>>>
>>>> Given that these patches only touch MFD/Extcon and extcon
>>>> is a subsystem designed to handle things like jack detection
>>>> isn't it really sufficient that you and Chanwoo have looked this
>>>> and are happy with it? Otherwise I really don't see anyway to
>>>> move this forward and would appreciate any suggestions?
>>>
>>> I'm positive about your patches. After receiving the ack from MFD maintainer
>>> I want to apply this patch-set on extcon git repository.
>>>
>>> Also, I reviewed this patch on previous patch[1].
>>> [1]https://lkml.org/lkml/2015/9/11/81
>>
>> As you said, this patch touch MFD and EXTCON subsystem.
>> If you get the Ack or agreement from MFD maintainer,
>> I'm willing to apply it on extcon git.
>>
>> Also, If this patch dont receive the additional ack message
>> unitl the end of this week, I'll merge patch1-3 on extcon-next branch
>> for Linux 4.4.
>
> Absolutely not!
>
> I should be extremely cross if you 'go over my head' and apply MFD
> patches without the correct Acks.
>

Just I mean that if there is any reply or opinion about patch.
But, You're right. It is misconception of me. We should check them cross before applying them.

Thanks,
Chanwoo Choi