Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection

Mark Brown
2015-10-13T15:13:17Z

[-- Attachment #1: Type: text/plain, Size: 1973 bytes --]

On Tue, Oct 13, 2015 at 09:02:18AM +0100, Lee Jones wrote:
> On Mon, 12 Oct 2015, Mark Brown wrote:
> > On Mon, Oct 12, 2015 at 09:45:54AM +0100, Charles Keepax wrote:

> > > I am guessing Mark is slightly hesitant to ack as he probably
> > > doesn't want to add reviewing all our jack detection bindings to
> > > his already fairly sizable work load and doing so here likely
> > > means it will be expected in the future. From talking to people at

> Providing Acks should not (and has not to my knowledge) be a binding
> contract to continue providing Acks. However, should more bindings be
> submitted which appear as though they are related to a particular
> maintainer, then sure, you'll be asked for your expert eye again.

It's a bit concerning when it seems like my review is becoming a blocker
for something and I don't understand why.

> > Pretty much (plus generally being busy at ELC-E last week) - if there's
> > specific questions that's one thing but if it's just general requests to
> > look at bindings then it seems like the relevant subsystem maintainers

> This is exactly my point. I am not the 'relevant subsystem
> maintainer' for these properties and subsequently know nothing of
> microphone detection, headsets, bias', etc. These look like Audio
> related properties to me (the uninitiated), which is why you were
> asked.

They're extcon things (and there are accompanying driver changes to the
extcon driver parsing them).

> > should have the confidence to review straightfoward device properties
> > like this.

> I don't think these bindings are particularly straightforward. The
> contain many terms which I'm unfamiliar with, and again, to me (the
> uninitiated) this looks like way too many bindings just to see if an
> audio jack is plugged in or not.

When your power budget is in the low double digit microamps and you're
trying to respond promptly and reliably to rapidly changing and variable
physical inputs it gets complicated.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]