Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

[Lee Jones <lee.jones@linaro.org>]

On Mon, 12 Oct 2015, Borun Fu wrote:

> This patch adds the mfd cell info for axp288 power key device.
> 
> Signed-off-by: Borun Fu <borun.fu@linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> ---
>  drivers/mfd/axp20x.c |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 3f576b7..3f4e11f 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = {
>  	},
>  };
>  
> +static struct resource axp288_power_button_resources[] = {
> +	{
> +		.name	= "PEK_DBR",
> +		.start	= AXP288_IRQ_POKN,
> +		.end	= AXP288_IRQ_POKN,
> +		.flags	= IORESOURCE_IRQ,
> +	},
> +	{
> +		.name	= "PEK_DBF",
> +		.start	= AXP288_IRQ_POKP,
> +		.end	= AXP288_IRQ_POKP,
> +		.flags	= IORESOURCE_IRQ,
> +	},
> +};
> +
>  static struct resource axp288_fuel_gauge_resources[] = {
>  	{
>  		.start = AXP288_IRQ_QWBTU,
> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>  		.resources = axp288_fuel_gauge_resources,
>  	},
>  	{
> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */

Doesn't this change insinuate that?

If axp20x-pek didn't work for AXP288 you wouldn't have put it in this
structure right? 

> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> +		.resources = axp288_power_button_resources,
> +	},
> +	{
>  		.name = "axp288_pmic_acpi",
>  	},
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog