From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932270AbbJMILz (ORCPT <rfc822;w@1wt.eu>);
	Tue, 13 Oct 2015 04:11:55 -0400
Received: from mail-wi0-f173.google.com ([209.85.212.173]:35496 "EHLO
	mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752917AbbJMILw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 13 Oct 2015 04:11:52 -0400
Date: Tue, 13 Oct 2015 09:11:48 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Borun Fu <borun.fu@linux.intel.com>
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org, fei.yang@intel.com,
        "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH] mfd: axp20x: Add a cell for the power button part of
 the,axp288 PMICs
Message-ID: <20151013081148.GZ17172@x1>
References: <561B5E55.3010802@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <561B5E55.3010802@linux.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 12 Oct 2015, Borun Fu wrote:

> This patch adds the mfd cell info for axp288 power key device.
> 
> Signed-off-by: Borun Fu <borun.fu@linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> ---
>  drivers/mfd/axp20x.c |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 3f576b7..3f4e11f 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = {
>  	},
>  };
>  
> +static struct resource axp288_power_button_resources[] = {
> +	{
> +		.name	= "PEK_DBR",
> +		.start	= AXP288_IRQ_POKN,
> +		.end	= AXP288_IRQ_POKN,
> +		.flags	= IORESOURCE_IRQ,
> +	},
> +	{
> +		.name	= "PEK_DBF",
> +		.start	= AXP288_IRQ_POKP,
> +		.end	= AXP288_IRQ_POKP,
> +		.flags	= IORESOURCE_IRQ,
> +	},
> +};
> +
>  static struct resource axp288_fuel_gauge_resources[] = {
>  	{
>  		.start = AXP288_IRQ_QWBTU,
> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>  		.resources = axp288_fuel_gauge_resources,
>  	},
>  	{
> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */

Doesn't this change insinuate that?

If axp20x-pek didn't work for AXP288 you wouldn't have put it in this
structure right? 

> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> +		.resources = axp288_power_button_resources,
> +	},
> +	{
>  		.name = "axp288_pmic_acpi",
>  	},
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog