From: Lee Jones <lee.jones@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
Steve Twiss <stwiss.opensource@diasemi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: da9062-core: Rename get_device_type to da9062_get_device_type
Date: Tue, 13 Oct 2015 09:18:04 +0100 [thread overview]
Message-ID: <20151013081804.GC17172@x1> (raw)
In-Reply-To: <1444386123.24317.1.camel@ingics.com>
On Fri, 09 Oct 2015, Axel Lin wrote:
> Rename get_device_type() to da9062_get_device_type().
> This function is only used in this file so make it static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/da9062-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index f80d947..a9ad024 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -198,7 +198,7 @@ static int da9062_clear_fault_log(struct da9062 *chip)
> return ret;
> }
>
> -int get_device_type(struct da9062 *chip)
> +static int da9062_get_device_type(struct da9062 *chip)
> {
> int device_id, variant_id, variant_mrc;
> int ret;
> @@ -466,7 +466,7 @@ static int da9062_i2c_probe(struct i2c_client *i2c,
> if (ret < 0)
> dev_warn(chip->dev, "Cannot clear fault log\n");
>
> - ret = get_device_type(chip);
> + ret = da9062_get_device_type(chip);
> if (ret)
> return ret;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-10-13 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 10:22 [PATCH] mfd: da9062-core: Rename get_device_type to da9062_get_device_type Axel Lin
2015-10-13 8:18 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013081804.GC17172@x1 \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).