From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752696AbbJMJI4 (ORCPT ); Tue, 13 Oct 2015 05:08:56 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:33211 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbbJMJIx (ORCPT ); Tue, 13 Oct 2015 05:08:53 -0400 Date: Tue, 13 Oct 2015 12:08:50 +0300 From: "Kirill A. Shutemov" To: yalin wang Cc: akpm@linux-foundation.org, vbabka@suse.cz, mgorman@techsingularity.net, mhocko@suse.com, rientjes@google.com, js1304@gmail.com, kirill.shutemov@linux.intel.com, hannes@cmpxchg.org, alexander.h.duyck@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm, page_alloc: reserve pageblocks for high-order atomic allocations on demand -fix Message-ID: <20151013090850.GA11942@node> References: <1444700544-22666-1-git-send-email-yalin.wang2010@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444700544-22666-1-git-send-email-yalin.wang2010@gmail.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 09:42:24AM +0800, yalin wang wrote: > There is a redundant check and a memory leak introduced by a patch in > mmotm. This patch removes an unlikely(order) check as we are sure order > is not zero at the time. It also checks if a page is already allocated > to avoid a memory leak. > > This is a fix to the mmotm patch > mm-page_alloc-reserve-pageblocks-for-high-order-atomic-allocations-on-demand.patch > > Signed-off-by: yalin wang > Acked-by: Mel Gorman Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov