From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752980AbbJMJ1A (ORCPT <rfc822;w@1wt.eu>);
	Tue, 13 Oct 2015 05:27:00 -0400
Received: from mail-wi0-f182.google.com ([209.85.212.182]:37344 "EHLO
	mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752942AbbJMJ04 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 13 Oct 2015 05:26:56 -0400
Date: Tue, 13 Oct 2015 10:26:52 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH v7 6/6] mfd: da9150: Use DEFINE_RES_IRQ_NAMED() help
 macro for IRQ resource
Message-ID: <20151013092652.GX32409@x1>
References: <cover.1444225050.git.Adam.Thomson.Opensource@diasemi.com>
 <d5715f971e87517c30dd07a9907fd8c223dd7650.1444225050.git.Adam.Thomson.Opensource@diasemi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d5715f971e87517c30dd07a9907fd8c223dd7650.1444225050.git.Adam.Thomson.Opensource@diasemi.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 07 Oct 2015, Adam Thomson wrote:

> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> Suggested-by: Lee Jones <lee.jones@linaro.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
> 
> Changes in v6:
>  - Rebase to v4.3-rc4
> 
> Changes in v5:
>  - Rebase to v4.2
> 
> Changes in v3:
>  - Initial version.
> 
>  drivers/mfd/da9150-core.c | 35 +++++------------------------------
>  1 file changed, 5 insertions(+), 30 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/da9150-core.c b/drivers/mfd/da9150-core.c
> index 85ca4b5..195fdcf 100644
> --- a/drivers/mfd/da9150-core.c
> +++ b/drivers/mfd/da9150-core.c
> @@ -355,39 +355,14 @@ static const struct regmap_irq_chip da9150_regmap_irq_chip = {
>  };
> 
>  static struct resource da9150_gpadc_resources[] = {
> -	{
> -		.name = "GPADC",
> -		.start = DA9150_IRQ_GPADC,
> -		.end = DA9150_IRQ_GPADC,
> -		.flags = IORESOURCE_IRQ,
> -	},
> +	DEFINE_RES_IRQ_NAMED(DA9150_IRQ_GPADC, "GPADC"),
>  };
> 
>  static struct resource da9150_charger_resources[] = {
> -	{
> -		.name = "CHG_STATUS",
> -		.start = DA9150_IRQ_CHG,
> -		.end = DA9150_IRQ_CHG,
> -		.flags = IORESOURCE_IRQ,
> -	},
> -	{
> -		.name = "CHG_TJUNC",
> -		.start = DA9150_IRQ_TJUNC,
> -		.end = DA9150_IRQ_TJUNC,
> -		.flags = IORESOURCE_IRQ,
> -	},
> -	{
> -		.name = "CHG_VFAULT",
> -		.start = DA9150_IRQ_VFAULT,
> -		.end = DA9150_IRQ_VFAULT,
> -		.flags = IORESOURCE_IRQ,
> -	},
> -	{
> -		.name = "CHG_VBUS",
> -		.start = DA9150_IRQ_VBUS,
> -		.end = DA9150_IRQ_VBUS,
> -		.flags = IORESOURCE_IRQ,
> -	},
> +	DEFINE_RES_IRQ_NAMED(DA9150_IRQ_CHG, "CHG_STATUS"),
> +	DEFINE_RES_IRQ_NAMED(DA9150_IRQ_TJUNC, "CHG_TJUNC"),
> +	DEFINE_RES_IRQ_NAMED(DA9150_IRQ_VFAULT, "CHG_VFAULT"),
> +	DEFINE_RES_IRQ_NAMED(DA9150_IRQ_VBUS, "CHG_VBUS"),
>  };
> 
>  static struct resource da9150_fg_resources[] = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog