From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932241AbbJMKvU (ORCPT ); Tue, 13 Oct 2015 06:51:20 -0400 Received: from bes.se.axis.com ([195.60.68.10]:38881 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932143AbbJMKvT (ORCPT ); Tue, 13 Oct 2015 06:51:19 -0400 Date: Tue, 13 Oct 2015 12:51:17 +0200 From: Rabin Vincent To: Namhyung Kim Cc: Jiri Olsa , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind Message-ID: <20151013105116.GB3628@axis.com> References: <1443379079-29133-1-git-send-email-rabin.vincent@axis.com> <1443379079-29133-2-git-send-email-rabin.vincent@axis.com> <20151012112423.GA20170@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2015 at 02:35:08PM +0200, Namhyung Kim wrote: > On Mon, Oct 12, 2015 at 8:24 PM, Jiri Olsa wrote: > > On Sun, Sep 27, 2015 at 08:37:56PM +0200, Rabin Vincent wrote: > >> Even if --symfs is used to point to the debug binaries, we send in the > >> non-debug filenames to libunwind, which leads to libunwind not finding > >> the debug frame. Fix this. > >> > >> Signed-off-by: Rabin Vincent > > > > cc-ing Namhyung on this one > > It seems that the dso->symsrc_filename can be NULL and it's unsafe to > call dwarf_find_debug_frame() with the NULL pointer. Other than that > looks good to me. Thanks, I will change it to fallback to dso->name if dso->symsrc_filename is NULL.